Bug 219141

Summary: [macOS] Add telemetry for things we believe are unused
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ggaren, jonlee, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Brent Fulgham
Reported 2020-11-18 19:00:07 PST
This patch adds telemetry to a set of sandbox features we believe are unused. We should measure, and confirm before removing.
Attachments
Patch (6.17 KB, patch)
2020-11-18 21:24 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2020-11-20 11:08 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.94 KB, patch)
2020-12-01 10:11 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.94 KB, patch)
2020-12-01 10:12 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.94 KB, patch)
2020-12-01 10:41 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-18 20:02:19 PST
<rdar://problem/71569084>
Brent Fulgham
Comment 2 2020-11-18 21:24:38 PST
Created attachment 414538 [details] Patch
Per Arne Vollan
Comment 3 2020-11-19 11:14:30 PST
Comment on attachment 414538 [details] Patch R=me. It might be good to make sure this does not introduce MotionMark regressions before landing, since adding reports for IOKit classes sometimes introduces performance regressions.
Brent Fulgham
Comment 4 2020-11-20 11:08:05 PST
Created attachment 414699 [details] Patch
Per Arne Vollan
Comment 5 2020-11-20 11:49:00 PST
Comment on attachment 414699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414699&action=review R=me. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:121 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 Does this rule already have telemetry? > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:140 > + (with telemetry-backtrace) Does this rule already have telemetry? > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:174 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 Does this rule also already have telemetry?
Brent Fulgham
Comment 6 2020-12-01 10:10:39 PST
Comment on attachment 414699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414699&action=review >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:121 >> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 > > Does this rule already have telemetry? You are right! I'll correct all of them like this.
Brent Fulgham
Comment 7 2020-12-01 10:11:51 PST
Created attachment 415145 [details] Patch for landing
Brent Fulgham
Comment 8 2020-12-01 10:12:35 PST
Created attachment 415146 [details] Patch for landing
Alex Christensen
Comment 9 2020-12-01 10:29:26 PST
Comment on attachment 415146 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=415146&action=review > Source/WebKit/ChangeLog:3 > + [macOS] Add telemetry for things we believe are unused It would be nice if this title had "sandbox" in it. "things" isn't very helpful.
Brent Fulgham
Comment 10 2020-12-01 10:41:25 PST
Created attachment 415148 [details] Patch for landing
Brent Fulgham
Comment 11 2020-12-01 10:42:26 PST
Comment on attachment 415146 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=415146&action=review >> Source/WebKit/ChangeLog:3 >> + [macOS] Add telemetry for things we believe are unused > > It would be nice if this title had "sandbox" in it. "things" isn't very helpful. Good point. I *think* I caught commit-queue before it landed.
EWS
Comment 12 2020-12-01 11:09:04 PST
Committed r270318: <https://trac.webkit.org/changeset/270318> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415148 [details].
Note You need to log in before you can comment on or make changes to this bug.