Bug 219126

Summary: Import web-platform-tests/compat tests from upstream
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, clopez, commit-queue, ews-watchlist, ryanhaddad, sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219162    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2020-11-18 15:46:32 PST
Import web-platform-tests/compat tests from usptream.
Comment 1 Chris Dumez 2020-11-18 15:48:29 PST
Created attachment 414503 [details]
Patch
Comment 2 Chris Dumez 2020-11-18 16:58:17 PST
Created attachment 414516 [details]
Patch
Comment 3 Sam Weinig 2020-11-18 17:21:02 PST
Comment on attachment 414516 [details]
Patch

rs=me
Comment 4 EWS 2020-11-18 19:38:46 PST
Committed r270009: <https://trac.webkit.org/changeset/270009>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414516 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-18 19:39:18 PST
<rdar://problem/71568463>
Comment 6 Aakash Jain 2020-11-19 08:01:36 PST
(In reply to EWS from comment #4)
> Committed r270009: <https://trac.webkit.org/changeset/270009>
This added two failing tests on ios-wk2. ios-wk2 ews indicated this failure. Should have waited for ews to complete before cq+ing the patch.

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcompat%2Fwebkit-box-clamp-bottom-border.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcompat%2Fidlharness.window.html
Comment 7 WebKit Commit Bot 2020-11-19 08:02:57 PST
Re-opened since this is blocked by bug 219162
Comment 8 Chris Dumez 2020-11-19 08:26:47 PST
Created attachment 414583 [details]
Patch
Comment 9 Simon Fraser (smfr) 2020-11-19 09:36:02 PST
Comment on attachment 414583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414583&action=review

> LayoutTests/imported/w3c/ChangeLog:3
> +        Import web-platform-tests/compat tests from usptream

usptream
Comment 10 Chris Dumez 2020-11-19 09:47:12 PST
Created attachment 414595 [details]
Patch
Comment 11 EWS 2020-11-19 12:50:57 PST
Committed r270045: <https://trac.webkit.org/changeset/270045>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414595 [details].
Comment 13 Chris Dumez 2020-11-19 13:52:30 PST
(In reply to Aakash Jain from comment #12)
> (In reply to EWS from comment #11)
> > Committed r270045: <https://trac.webkit.org/changeset/270045>
> This seems to have broken 9 ios tests this time. EWS indicated this failure
> in: https://ews-build.webkit.org/#/builders/51/builds/2287
> 
> Again, should have waited for EWS to complete before cq+ing the patch.
> 
> 
> See:
> https://results.webkit.org/?suite=layout-tests&suite=layout-
> tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-
> tests&suite=layout-tests&suite=layout-tests&suite=layout-
> tests&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Fclick%2Fauxclick_event.html&test=imported%2Fw3c%2Fweb-
> platform-tests%2Fuievents%2Fclick%2Fclick_event_target_child_parent.
> html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Fclick%2Fclick_event_target_siblings.
> html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Fclick%2Fclick_events_on_input.
> html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Fclick%2Fdblclick_event_mouse.
> html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Fmouse%2Flayout_change_should_fire_mouseover.
> html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Fmouse%2Fmouseevent_move_button.
> html&test=imported%2Fw3c%2Fweb-platform-tests%2Fuievents%2Forder-of-
> events%2Ffocus-events%2Ffocus.html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fuievents%2Forder-of-events%2Fmouse-events%2Fmouseover-out.html

Those failures are unrelated to this bug. However, they were caused by one of my other commits so I am working on fixing them.