Bug 219117

Summary: Menu Bar support for app highlights in book.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2020-11-18 14:53:50 PST
Menu Bar support for app highlights in book.
Attachments
Patch (3.36 KB, patch)
2020-11-18 14:57 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.36 KB, patch)
2020-11-18 18:17 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-11-18 14:57:53 PST
Created attachment 414489 [details] Patch
Wenson Hsieh
Comment 2 2020-11-18 17:15:35 PST
Comment on attachment 414489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414489&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8612 > + [[UIMenuController sharedMenuController] setMenuItems:@[ addHighlightCurrentGroupItem.get(), addHighlightNewGroupItem.get()]]; Nit - maybe an extra space after `addHighlightNewGroupItem.get()` to balance out the leading space after @[?
Megan Gardner
Comment 3 2020-11-18 18:17:56 PST
Created attachment 414525 [details] Patch for landing
EWS
Comment 4 2020-11-18 19:17:16 PST
Committed r270007: <https://trac.webkit.org/changeset/270007> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414525 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-18 19:18:17 PST
<rdar://problem/71567873>
Note You need to log in before you can comment on or make changes to this bug.