Bug 219117

Summary: Menu Bar support for app highlights in book.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Megan Gardner 2020-11-18 14:53:50 PST 
Menu Bar support for app highlights in book.
Comment 1 Megan Gardner 2020-11-18 14:57:53 PST 
Created attachment 414489 [details]
Patch
Comment 2 Wenson Hsieh 2020-11-18 17:15:35 PST 
Comment on attachment 414489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414489&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8612
> +        [[UIMenuController sharedMenuController] setMenuItems:@[ addHighlightCurrentGroupItem.get(), addHighlightNewGroupItem.get()]];

Nit - maybe an extra space after `addHighlightNewGroupItem.get()` to balance out the leading space after @[?
Comment 3 Megan Gardner 2020-11-18 18:17:56 PST 
Created attachment 414525 [details]
Patch for landing
Comment 4 EWS 2020-11-18 19:17:16 PST 
Committed r270007: <https://trac.webkit.org/changeset/270007>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414525 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-18 19:18:17 PST 
<rdar://problem/71567873>