Summary: | REGRESSION (r269824): YouTube media control bar sometimes flickers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | Compositing | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2020-11-16 19:10:16 PST
Created attachment 414299 [details]
Patch
Comment on attachment 414299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414299&action=review > LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:4 > + <style type="text/css" media="screen"> No need for `type="text/css" media="screen"` > LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:9 > + -webkit-transform: translateZ(0); no prefix! > LayoutTests/compositing/repaint/transparent-layer-repaint.html:9 > + -webkit-transform: translateZ(0); No prefix. > LayoutTests/compositing/repaint/transparent-layer-repaint.html:25 > + await UIHelper.ensurePresentationUpdate(); Maybe UIHelper.renderingUpdate()? > LayoutTests/compositing/repaint/transparent-layer-repaint.html:27 > + await UIHelper.ensurePresentationUpdate(); Same (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 414299 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414299&action=review > > > LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:4 > > + <style type="text/css" media="screen"> > > No need for `type="text/css" media="screen"` Erk, I removed them from the other one (obviously I started with a really antique test). > > LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:9 > > + -webkit-transform: translateZ(0); > > no prefix! TRUE > > LayoutTests/compositing/repaint/transparent-layer-repaint.html:9 > > + -webkit-transform: translateZ(0); > > No prefix. > > > LayoutTests/compositing/repaint/transparent-layer-repaint.html:25 > > + await UIHelper.ensurePresentationUpdate(); > > Maybe UIHelper.renderingUpdate()? Whazzat. I'll look! > > LayoutTests/compositing/repaint/transparent-layer-repaint.html:27 > > + await UIHelper.ensurePresentationUpdate(); > > Same Created attachment 414301 [details]
Patch
Committed r269895: <https://trac.webkit.org/changeset/269895> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414301 [details]. |