Bug 219015

Summary: AppleWin can't start due to "Failed to determine path to AAS directory." because iTunes changed the registry key
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ews-watchlist, keith_miller, mark.lam, msaboff, pvollan, saam, twilco.o, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fujii.hironori: review-
Patch none

Fujii Hironori
Reported 2020-11-16 18:09:16 PST
AppleWin can't start due to "Failed to determine path to AAS directory." because iTunes changed the registry key [webkit-help] Compiling webkit on windows. https://lists.webkit.org/pipermail/webkit-help/2020-November/004169.html "\HKEY_LOCAL_MACHINE\SOFTWARE\Apple Computer, Inc.\iTunes" is the new registry key.
Attachments
Patch (2.90 KB, patch)
2020-11-16 18:45 PST, Fujii Hironori 		fujii.hironori: review-
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2021-03-18 23:14 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-11-16 18:45:57 PST
Created attachment 414297 [details] Patch
Fujii Hironori
Comment 2 2020-11-16 19:47:14 PST
Oh, Win EWS bot passed. I'm surprised. I hope this change won't break post-commit buildbot. 🤞
Alex Christensen
Comment 3 2020-11-17 08:12:43 PST
Comment on attachment 414297 [details] Patch This looks likely to break things for us internally. Could we check both paths and allow one to not exist instead?
Radar WebKit Bug Importer
Comment 4 2020-11-26 03:17:22 PST
<rdar://problem/71747677>
Tyler Wilcock
Comment 5 2021-03-18 23:14:38 PDT
Created attachment 423695 [details] Patch
Tyler Wilcock
Comment 6 2021-03-18 23:16:16 PDT
I ran into this issue as well. I've uploaded a patch that looks for the Apple Application Support directory first, then falls back to the iTunes installation directory if necessary.
EWS
Comment 7 2021-03-22 12:00:49 PDT
Committed r274769: <https://commits.webkit.org/r274769> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423695 [details].
Note You need to log in before you can comment on or make changes to this bug.