Bug 218885

Summary:

[WASM-References] Remove subtyping rule for externref and funcref

Product:

WebKit

Reporter:

Dmitry <dbezhetskov>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Dmitry

Reported 2020-11-12 21:16:17 PST

[WASM-References] Remove subtyping rule for externref and funcref

Attachments
Patch (10.35 KB, patch) 2020-11-12 21:21 PST, Dmitry	no flags	Details Formatted Diff Diff
Patch (31.23 KB, patch) 2020-11-16 02:09 PST, Dmitry	no flags	Details Formatted Diff Diff
Patch (31.97 KB, patch) 2020-11-16 22:29 PST, Dmitry	no flags	Details Formatted Diff Diff
Patch (32.79 KB, patch) 2020-11-16 23:30 PST, Dmitry	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (32.93 KB, patch) 2020-11-17 01:41 PST, Dmitry	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dmitry

Comment 1 2020-11-12 21:21:13 PST

Created attachment 414003 [details] Patch

Yusuke Suzuki

Comment 2 2020-11-14 02:03:00 PST

Comment on attachment 414003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review The design looks good. Can you check JSC test failure? > Source/JavaScriptCore/wasm/WasmFormat.h:81 > +inline bool isSubtype(Type sub, Type parent) { return sub == parent; } Let's remove this function since `sub == parent` is the same type.

Dmitry

Comment 3 2020-11-16 02:09:13 PST

Created attachment 414206 [details] Patch

Dmitry

Comment 4 2020-11-16 02:10:42 PST

Comment on attachment 414003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review >> Source/JavaScriptCore/wasm/WasmFormat.h:81 >> +inline bool isSubtype(Type sub, Type parent) { return sub == parent; } > > Let's remove this function since `sub == parent` is the same type. Thanks! Removed this.

Dmitry

Comment 5 2020-11-16 22:29:38 PST

Created attachment 414308 [details] Patch

Dmitry

Comment 6 2020-11-16 23:30:02 PST

Created attachment 414312 [details] Patch

Dmitry

Comment 7 2020-11-17 01:41:14 PST

Created attachment 414319 [details] Patch

Yusuke Suzuki

Comment 8 2020-11-18 20:07:03 PST

Comment on attachment 414319 [details] Patch r=me