Summary: | Update ANGLE 2020-11-12 | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||||||||||||
Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | annulen, dino, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio, smoley, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 126404, 244008 | ||||||||||||||||||||
Attachments: |
|
Description
James Darpinian
2020-11-12 16:58:35 PST
Created attachment 413986 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Created attachment 414291 [details]
Patch
Created attachment 414294 [details]
Patch
Created attachment 414390 [details]
Patch
Created attachment 414394 [details]
Patch
Created attachment 414630 [details]
Patch
Created attachment 414631 [details]
Patch
This is ready. Assuming it passes EWS, please CQ+ if the review looks good. I am off tomorrow. Comment on attachment 414631 [details]
Patch
Great work James improving the tooling around these rolls and completing this big one!
Reviewed changes.diff in detail - looks very good, only a couple of diffs relative to upstream at this point. r+ / cq+
commit-queue failed to commit attachment 414631 [details] to WebKit repository.
Comment on attachment 414631 [details]
Patch
CQ claimed the patch wasn't marked cq+. Trying again.
commit-queue failed to commit attachment 414631 [details] to WebKit repository.
Ah, tab characters. I can remove those. Created attachment 414704 [details]
Patch
Committed r270129: <https://trac.webkit.org/changeset/270129> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414704 [details]. Reverted r270129, r270194, and r270258 for reason: r270129 broke macCatalyst build Committed r270272: <https://trac.webkit.org/changeset/270272> Sorry for the breakage. Is it possible for me to test the maccatalyst build? I don't see a public EWS bot for it and I don't see a way to build it locally. Dean helped reland these three patches in: Re-landing r270129, r270194, and r270258. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@270351 268f45cc-cd09-0410-ab3c-d52691b4dbfc http://trac.webkit.org/changeset/270351 (doesn't load in any reasonable period of time) Thank you Dean for taking care of this! |