Bug 218854

Summary: [GTK][WPE] FilterInfo must cleared when reusing BitmapTextureGL
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, cmarcelo, ews-watchlist, Hironori.Fujii, kondapallykalyan, luiz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Miguel Gomez 2020-11-12 09:51:45 PST 
When a BitmapTextureGL is reused, its internal values are reset (flags, internal texture, and content). But the FilterInfo variable is not, so the every time that BitmapTextureGL is painted it will use the the old filter, altering the result.
Comment 1 Miguel Gomez 2020-11-12 09:55:02 PST 
Created attachment 413946 [details]
Patch
Comment 2 Fujii Hironori 2020-11-12 13:33:09 PST 
Good catch.
Are there any existing tests failing? If so, please add a comment about it. If not, can you add a new test?
Comment 3 Carlos Garcia Campos 2020-11-12 23:46:40 PST 
I think this will fix tests but on top pach attached to bug #215445. So, it will be covered by backdrop filter tests.
Comment 4 Miguel Gomez 2020-11-13 00:05:49 PST 
(In reply to Carlos Garcia Campos from comment #3)
> I think this will fix tests but on top pach attached to bug #215445. So, it
> will be covered by backdrop filter tests.

Yes, this together with the fix to bug #215445 will fix several backdrop filter related bugs.
Comment 5 EWS 2020-11-13 00:22:51 PST 
Committed r269765: <https://trac.webkit.org/changeset/269765>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413946 [details].