Bug 218836 – Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'target.DOMAgent.hideHighlight')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect any page
2. go to the Graphics Tab
3. close Web Inspector
4. open Web Inspector

Uncaught Exceptions:
-----------------------
 - TypeError: undefined is not an object (evaluating 'target.DOMAgent.hideHighlight') (at DOMManager.js:576:24)
    hideDOMNodeHighlight @ DOMManager.js:576:24
    detached @ GraphicsOverviewContentView.js:81:43
    _didMoveToWindow @ View.js:267:26
    _didMoveToParent @ View.js:239:30
    removeSubview @ View.js:129:30
    _hideEntry @ ContentViewContainer.js:464:31
    showBackForwardEntryForIndex @ ContentViewContainer.js:161:28
    showContentView @ ContentViewContainer.js:141:42
    initialLayout @ GraphicsTabContentView.js:206:44
    _layoutSubtree @ View.js:281:31
    _layoutSubtree @ View.js:304:32
    _layoutSubtree @ View.js:304:32
    updateLayout @ View.js:160:28
    ? @ Main.js:1908:31
    ? @ Main.js:1927:32
    dispatch @ Object.js:130:35
    dispatchEventToListeners @ Object.js:138:17
    collapsed @ Sidebar.js:131:38
    showDetailsSidebarPanels @ ContentBrowserTabContentView.js:196:30
    _contentBrowserCurrentRepresentedObjectsDidChange @ ContentBrowserTabContentView.js:316:38
    dispatch @ Object.js:130:35
    dispatchEventToListeners @ Object.js:138:17
    ? @ ContentBrowser.js:96:42
    _execute @ Debouncer.js:132:29
    force @ Debouncer.js:63:22
    _currentContentViewDidChange @ ContentBrowser.js:542:72
    dispatch @ Object.js:130:35
    dispatchEventToListeners @ Object.js:138:17
    showBackForwardEntryForIndex @ ContentViewContainer.js:164:38
    showContentView @ ContentViewContainer.js:141:42
    initialLayout @ GraphicsTabContentView.js:206:44
    _layoutSubtree @ View.js:281:31
    _layoutSubtree @ View.js:304:32
    _layoutSubtree @ View.js:304:32
    updateLayout @ View.js:160:28
    ? @ Main.js:1908:31
    ? @ Main.js:1927:32
    dispatch @ Object.js:130:35
    dispatchEventToListeners @ Object.js:138:17
    _handleSidebarWidthDidChange @ MultiSidebar.js:315:38
    dispatch @ Object.js:130:35
    dispatchEventToListeners @ Object.js:138:17
    _recalculateWidth @ SingleSidebar.js:185:38
    width @ SingleSidebar.js:73:31
    _showDetailsSidebarPanelsForTabContentView @ TabBrowser.js:455:20
    _tabBarItemSelected @ TabBrowser.js:254:56
    dispatch @ Object.js:130:35
    dispatchEventToListeners @ Object.js:138:17
    selectTabBarItem @ TabBar.js:414:38
    selectedTabBarItem @ TabBar.js:386:30
    ? @ Main.js:527:18
-----------------------

Notes:
Inspected URL:        (unknown)
Loading completed:    false
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko)

I encountered this while living on bug 218678, so this may be fallout (or a preemptive fix depending on how you look at it) from that.

[Devin Rousso]

Created attachment 413894 [details]
Patch

[Blaze Burg]

Comment on attachment 413894 [details]
Patch

r=me

Does this need to be changed in other places as well?

[Radar WebKit Bug Importer]

<rdar://problem/71345058>

[EWS]

Committed r269756: <https://trac.webkit.org/changeset/269756>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413894 [details].