Bug 218831

Summary: Improve update-angle script and move to Tools/Scripts
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: New BugsAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, dino, ews-watchlist, graouts, kbr, kondapallykalyan, smoley, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description James Darpinian 2020-11-11 16:51:23 PST 
Improve update-angle script and move to Tools/Scripts
Comment 1 James Darpinian 2020-11-11 16:55:32 PST 
Created attachment 413887 [details]
Patch
Comment 2 EWS Watchlist 2020-11-11 16:56:26 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 James Darpinian 2020-11-11 17:00:26 PST 
Created attachment 413888 [details]
Patch
Comment 4 Kenneth Russell 2020-11-11 17:14:05 PST 
Comment on attachment 413888 [details]
Patch

Great work James continuing to simplify rolls of ANGLE into WebKit! r+
Comment 5 James Darpinian 2020-11-12 16:48:11 PST 
Created attachment 413983 [details]
Patch
Comment 6 Kenneth Russell 2020-11-12 17:35:37 PST 
Comment on attachment 413983 [details]
Patch

Still looks good to me! Please look into the style complaints. r+
Comment 7 Radar WebKit Bug Importer 2020-11-12 18:50:58 PST 
<rdar://problem/71353949>
Comment 8 James Darpinian 2020-11-19 16:36:55 PST 
Created attachment 414636 [details]
Patch
Comment 9 James Darpinian 2020-11-19 16:38:12 PST 
Created attachment 414637 [details]
Patch
Comment 10 EWS 2020-11-19 17:24:16 PST 
Committed r270063: <https://trac.webkit.org/changeset/270063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414637 [details].