Bug 218812

Summary: Font::platformBoundsForGlyph() should provide a boundingRect pointer to CTFontGetBoundingRectsForGlyphs()
Product: WebKit Reporter: Julian Gonzalez <julian_a_gonzalez>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, koivisto, mmaxfield, rniwa, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Julian Gonzalez
Reported 2020-11-11 11:02:22 PST
Pass a pointer to a stack-allocated boundingRect to CTFontGetBoundingRectsForGlyphs() in Font::platformBoundsForGlyph(). Also take a look at Font::isProbablyOnlyUsedToRenderIcons(), as it has the same issue. <rdar://problem/70738704>
Attachments
Patch (2.64 KB, patch)
2020-11-11 11:30 PST, Julian Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julian Gonzalez
Comment 1 2020-11-11 11:30:04 PST
Created attachment 413843 [details] Patch
EWS
Comment 2 2020-11-15 00:56:45 PST
Committed r269823: <https://trac.webkit.org/changeset/269823> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413843 [details].
Darin Adler
Comment 3 2020-11-15 15:52:39 PST
Comment on attachment 413843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413843&action=review > Source/WebCore/ChangeLog:9 > + Provide a zero CGRect boundingRect pointer in two places where the count argument > + to CTFontGetBoundingRectsForGlyphs() is already 1. The code below provides an *uninitialized* CGRect, not a zero CGRect. Do we need a zero CGRect?
Julian Gonzalez
Comment 4 2020-11-18 10:59:06 PST
Good catch, it is just a plain struct. I will add code to zero this.
Note You need to log in before you can comment on or make changes to this bug.