Summary: | REGRESSION(r269662): [GTK][WPE] Build broken on Ubuntu-18.04 bots | ||
---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bugs-noreply, darin, dpino, rniwa |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=218726 |
Description
Carlos Alberto Lopez Perez
2020-11-11 06:04:19 PST
Hm... Maybe we need to explicitly instantiate all variants of treeOrder. Try adding the following lines to BoundaryPoints.cpp? template PartialOrdering treeOrder<Tree>(const BoundaryPoint&, const BoundaryPoint&); template PartialOrdering treeOrder< ShadowIncludingTree >(const BoundaryPoint&, const BoundaryPoint&); template PartialOrdering treeOrder<ComposedTree>(const BoundaryPoint&, const BoundaryPoint&) Yes that should work; this is a non-unified build failure. We might not need all three of those. Just the <Tree> one would fix all the errors above. (In reply to Darin Adler from comment #2) > Yes that should work; this is a non-unified build failure. > > We might not need all three of those. Just the <Tree> one would fix all the > errors above. Right, the patch fixed the issue (I tested it in the affected bot). I landed the patch as it was originally suggested in r269715, just a few minutes ago. |