REGRESSION(r269642) [GStreamer][WebRTC] Unexpected results after update to M87

• Component: WebRTC
• Status: RESOLVED FIXED

[Lauro Moura]

The list of tests below are crashing/failing/timing out after the libwebrtc update in r269642.

Many of these cases are emitting error messages like:

"Failed to set remote offer sdp: Failed to set remote video description send parameters for m-section with mid='1'."
"Failed to set local offer sdp: Failed to set local video description recv parameters for m-section with mid='0'."

Detailed crashlogs for the two crashes in the following comments.

Link to the first GTK-Release test run with these failures: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r269646%20(16908)/results.html

# Crashes

webrtc/direction-change.html
webrtc/h264-packetization-mode.html

# Failures
webrtc/connection-state.html
webrtc/createOfferAnswer.html
webrtc/disable-encryption.html
webrtc/ephemeral-certificates-and-cnames.html
webrtc/libwebrtc/setLocalDescriptionCrash.html
webrtc/msection-recycling.html
webrtc/multi-audio.html
webrtc/release-after-getting-track.html
webrtc/remove-track.html
webrtc/utf8-sdp.html
webrtc/video-autoplay.html
webrtc/video-getParameters.html
webrtc/video-mediastreamtrack-stats.html
webrtc/video-receivers.html
webrtc/video-replace-track-to-null.html
webrtc/video-stats.html

# Timeouts
fast/mediastream/RTCPeerConnection-statsSelector.html
webrtc/concurrentVideoPlayback.html
webrtc/h264-baseline.html
webrtc/ice-candidate-sdpMLineIndex.html
webrtc/peerconnection-page-cache-long.html
webrtc/peerconnection-page-cache.html

[Lauro Moura]

Created attachment 413772 [details]
webrtc/direction-change.html crash log

[Lauro Moura]

Created attachment 413773 [details]
webrtc/h264-packetization-mode.html crash log

Similar to the first one.

[Lauro Moura]

Gardened in r269672.

[Lauro Moura]

webrtc/webrtc-transform.html

--- /home/lauro/dev/WebKit/layout-test-results/webrtc/webrtc-transform-expected.txt
+++ /home/lauro/dev/WebKit/layout-test-results/webrtc/webrtc-transform-actual.txt
@@ -1,5 +1,8 @@
+CONSOLE MESSAGE: Unhandled Promise Rejection: InvalidAccessError: Failed to set remote offer sdp: Failed to set remote video description send parameters for m-section with mid='0'.
 
 
+Harness Error (FAIL), message = Failed to set remote offer sdp: Failed to set remote video description send parameters for m-section with mid='0'.
+
 PASS audio exchange with transform
-PASS video exchange with transform
+FAIL video exchange with transform promise_test: Unhandled rejection with value: "Test timed out"
 
(Test was added in r269764)

[Víctor M. Jáquez L.]

Created attachment 414680 [details]
Patch

[Víctor M. Jáquez L.]

Created attachment 414683 [details]
Patch

[Philippe Normand]

Comment on attachment 414683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414683&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoCommon.cpp:39
> +        { { cricket::kH264FmtpProfileLevelId, *profileString },
> +            { cricket::kH264FmtpLevelAsymmetryAllowed, "1" },
> +            { cricket::kH264FmtpPacketizationMode, packetizationMode } });

Indentation looks odd here :)

[Víctor M. Jáquez L.]

(In reply to Philippe Normand from comment #7)
> Comment on attachment 414683 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414683&action=review
> 
> > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoCommon.cpp:39
> > +        { { cricket::kH264FmtpProfileLevelId, *profileString },
> > +            { cricket::kH264FmtpLevelAsymmetryAllowed, "1" },
> > +            { cricket::kH264FmtpPacketizationMode, packetizationMode } });
> 
> Indentation looks odd here :)

Indeed, but it's what webkit-patch accepted (4 spaces indentation).

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 414683 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Víctor M. Jáquez L.]

Created attachment 414936 [details]
Patch

[EWS]

Committed r270190: <https://trac.webkit.org/changeset/270190>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414936 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71762858>