Bug 218764

Summary: [WK2] Only the first wheel event in a gesture should be cancelable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: UI EventsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, changseok, clord, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, kangil.han, kondapallykalyan, luiz, pdr, pnormand, simon.fraser, thorton, tonikitoo, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219547
Bug Depends on: 219050, 219213, 219236, 219241, 219373, 219384    
Bug Blocks: 219547    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
thorton: review+, ews-feeder: commit-queue-
Patch none

Description Simon Fraser (smfr) 2020-11-10 12:01:52 PST 
We should only report the first wheel event in a sequence as cancelable: https://w3c.github.io/uievents/#event-type-wheel
Comment 1 Radar WebKit Bug Importer 2020-11-10 12:02:16 PST 
<rdar://problem/71248946>
Comment 2 Simon Fraser (smfr) 2020-11-13 18:29:35 PST 
*** Bug 218765 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2020-11-13 18:30:58 PST Comment hidden (obsolete)
Comment 4 Simon Fraser (smfr) 2020-11-13 19:37:09 PST Comment hidden (obsolete)
Comment 5 Simon Fraser (smfr) 2020-11-13 19:49:37 PST Comment hidden (obsolete)
Comment 6 Simon Fraser (smfr) 2020-11-13 19:58:38 PST Comment hidden (obsolete)
Comment 7 Simon Fraser (smfr) 2020-11-20 16:40:57 PST Comment hidden (obsolete)
Comment 8 Simon Fraser (smfr) 2020-11-20 18:49:40 PST Comment hidden (obsolete)
Comment 9 Simon Fraser (smfr) 2020-11-20 19:00:06 PST Comment hidden (obsolete)
Comment 10 Simon Fraser (smfr) 2020-12-03 14:31:28 PST Comment hidden (obsolete)
Comment 11 Simon Fraser (smfr) 2020-12-03 14:47:19 PST 
Created attachment 415351 [details]
Patch
Comment 12 Simon Fraser (smfr) 2020-12-03 22:00:22 PST 
Created attachment 415387 [details]
Patch
Comment 13 EWS 2020-12-03 23:10:30 PST 
Committed r270425: <https://trac.webkit.org/changeset/270425>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415387 [details].
Comment 14 Philippe Normand 2020-12-09 09:42:09 PST 
Seems like this broke scrolling in GTK... I can't scroll any page with current ToT. Reverting this commit brings my wheel to a functional state.
Comment 15 Chris Lord 2020-12-09 10:02:55 PST 
(In reply to Philippe Normand from comment #14)
> Seems like this broke scrolling in GTK... I can't scroll any page with
> current ToT. Reverting this commit brings my wheel to a functional state.

lmoura is working on this regression in bug 219547.