Bug 218764

Summary:

[WK2] Only the first wheel event in a gesture should be cancelable

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

UI Events

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cgarcia, changseok, clord, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, kangil.han, kondapallykalyan, luiz, pdr, pnormand, simon.fraser, thorton, tonikitoo, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=219547

Bug Depends on:

219050, 219213, 219236, 219241, 219373, 219384

Bug Blocks:

219547

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	thorton: review+, ews-feeder: commit-queue-
Patch	none

Simon Fraser (smfr)

Reported 2020-11-10 12:01:52 PST

We should only report the first wheel event in a sequence as cancelable: https://w3c.github.io/uievents/#event-type-wheel

Attachments
Patch (49.37 KB, patch) 2020-11-13 18:30 PST, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (56.46 KB, patch) 2020-11-13 19:37 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (56.46 KB, patch) 2020-11-13 19:49 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (56.44 KB, patch) 2020-11-13 19:58 PST, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (81.64 KB, patch) 2020-11-20 16:40 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (57.26 KB, patch) 2020-11-20 18:49 PST, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (60.85 KB, patch) 2020-11-20 19:00 PST, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (32.20 KB, patch) 2020-12-03 14:31 PST, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (32.06 KB, patch) 2020-12-03 14:47 PST, Simon Fraser (smfr)	thorton: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (36.28 KB, patch) 2020-12-03 22:00 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-11-10 12:02:16 PST

<rdar://problem/71248946>

Simon Fraser (smfr)

Comment 2 2020-11-13 18:29:35 PST

*** Bug 218765 has been marked as a duplicate of this bug. ***

Simon Fraser (smfr)

Comment 3 2020-11-13 18:30:58 PST Comment hidden (obsolete)

Created attachment 414114 [details] Patch

Simon Fraser (smfr)

Comment 4 2020-11-13 19:37:09 PST Comment hidden (obsolete)

Created attachment 414116 [details] Patch

Simon Fraser (smfr)

Comment 5 2020-11-13 19:49:37 PST Comment hidden (obsolete)

Created attachment 414117 [details] Patch

Simon Fraser (smfr)

Comment 6 2020-11-13 19:58:38 PST Comment hidden (obsolete)

Created attachment 414119 [details] Patch

Simon Fraser (smfr)

Comment 7 2020-11-20 16:40:57 PST Comment hidden (obsolete)

Created attachment 414745 [details] Patch

Simon Fraser (smfr)

Comment 8 2020-11-20 18:49:40 PST Comment hidden (obsolete)

Created attachment 414748 [details] Patch

Simon Fraser (smfr)

Comment 9 2020-11-20 19:00:06 PST Comment hidden (obsolete)

Created attachment 414749 [details] Patch

Simon Fraser (smfr)

Comment 10 2020-12-03 14:31:28 PST Comment hidden (obsolete)

Created attachment 415347 [details] Patch

Simon Fraser (smfr)

Comment 11 2020-12-03 14:47:19 PST

Created attachment 415351 [details] Patch

Simon Fraser (smfr)

Comment 12 2020-12-03 22:00:22 PST

Created attachment 415387 [details] Patch

EWS

Comment 13 2020-12-03 23:10:30 PST

Committed r270425: <https://trac.webkit.org/changeset/270425> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415387 [details].

Philippe Normand

Comment 14 2020-12-09 09:42:09 PST

Seems like this broke scrolling in GTK... I can't scroll any page with current ToT. Reverting this commit brings my wheel to a functional state.

Chris Lord

Comment 15 2020-12-09 10:02:55 PST

(In reply to Philippe Normand from comment #14) > Seems like this broke scrolling in GTK... I can't scroll any page with > current ToT. Reverting this commit brings my wheel to a functional state. lmoura is working on this regression in bug 219547.

Note You need to log in before you can comment on or make changes to this bug.