| Summary: | Fix for LayoutTests/accessibility/mac/search-predicate.html in isolated tree mode. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-11-09 18:34:02 PST
Created attachment 413652 [details]
Patch
Created attachment 413690 [details]
Patch
Comment on attachment 413690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413690&action=review > Source/WebCore/ChangeLog:11 > + - Added handling of "AXIsOnScreen" attribute to WebAccessibilityOobjectWrapperMac. Spelling error here > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:506 > + bool isVisible() const override { return boolAttributeValue(AXPropertyName::IsVisible); } If we cache this we’ll need to update this value on objects after a scroll event right? Committed r269635: <https://trac.webkit.org/changeset/269635> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413690 [details]. |