Bug 218690

Summary:

[LFC][Integration] Cleanup LayoutIntegration::Line interface

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

alan

Reported 2020-11-07 13:00:34 PST

ssia

Attachments
Patch (1.86 KB, patch) 2020-11-07 13:02 PST, alan	no flags	Details Formatted Diff Diff
Patch (16.26 KB, patch) 2020-11-07 16:15 PST, alan	no flags	Details Formatted Diff Diff
Patch (16.36 KB, patch) 2020-11-08 10:40 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2020-11-07 13:02:11 PST

Created attachment 413533 [details] Patch

alan

Comment 2 2020-11-07 16:15:58 PST

Created attachment 413536 [details] Patch

Daniel Bates

Comment 3 2020-11-07 23:42:25 PST

Comment on attachment 413536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413536&action=review > Source/WebCore/layout/inlineformatting/InlineLineGeometry.h:38 > + InlineLineGeometry(const InlineRect& lineLogicalRect, const InlineLayoutSize& lineBoxLogicalSize, InlineLayoutUnit aligmentBaseline, InlineLayoutUnit horizontalAlignmentOffset); Ok as-is. Consider removing names for first 2 params now that they have different types.

Antti Koivisto

Comment 4 2020-11-08 06:45:43 PST

Comment on attachment 413536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413536&action=review > Source/WebCore/layout/integration/LayoutIntegrationPagination.cpp:134 > moveVertically(line.rect(), offset), > + line.rect().size(), > moveVertically(line.rect(), offset), Not from this patch but the last one should be enclosingRect().

alan

Comment 5 2020-11-08 10:40:04 PST

Created attachment 413542 [details] Patch

EWS

Comment 6 2020-11-08 12:06:03 PST

Committed r269571: <https://trac.webkit.org/changeset/269571> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413542 [details].

Radar WebKit Bug Importer

Comment 7 2020-11-08 12:07:18 PST

<rdar://problem/71168177>

alan

Comment 8 2020-11-09 13:09:36 PST

(In reply to Daniel Bates from comment #3) > Comment on attachment 413536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413536&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineGeometry.h:38 > > + InlineLineGeometry(const InlineRect& lineLogicalRect, const InlineLayoutSize& lineBoxLogicalSize, InlineLayoutUnit aligmentBaseline, InlineLayoutUnit horizontalAlignmentOffset); > > Ok as-is. Consider removing names for first 2 params now that they have > different types. I'd rather keep them as one is about the line while the other is about the line box geometry.

Note You need to log in before you can comment on or make changes to this bug.