Bug 218690

Summary: [LFC][Integration] Cleanup LayoutIntegration::Line interface
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2020-11-07 13:00:34 PST 
ssia
Comment 1 zalan 2020-11-07 13:02:11 PST 
Created attachment 413533 [details]
Patch
Comment 2 zalan 2020-11-07 16:15:58 PST 
Created attachment 413536 [details]
Patch
Comment 3 Daniel Bates 2020-11-07 23:42:25 PST 
Comment on attachment 413536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413536&action=review

> Source/WebCore/layout/inlineformatting/InlineLineGeometry.h:38
> +    InlineLineGeometry(const InlineRect& lineLogicalRect, const InlineLayoutSize& lineBoxLogicalSize, InlineLayoutUnit aligmentBaseline, InlineLayoutUnit horizontalAlignmentOffset);

Ok as-is. Consider removing names for first 2 params now that they have different types.
Comment 4 Antti Koivisto 2020-11-08 06:45:43 PST 
Comment on attachment 413536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413536&action=review

> Source/WebCore/layout/integration/LayoutIntegrationPagination.cpp:134
>              moveVertically(line.rect(), offset),
> +            line.rect().size(),
>              moveVertically(line.rect(), offset),

Not from this patch but the last one should be enclosingRect().
Comment 5 zalan 2020-11-08 10:40:04 PST 
Created attachment 413542 [details]
Patch
Comment 6 EWS 2020-11-08 12:06:03 PST 
Committed r269571: <https://trac.webkit.org/changeset/269571>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413542 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-08 12:07:18 PST 
<rdar://problem/71168177>
Comment 8 zalan 2020-11-09 13:09:36 PST 
(In reply to Daniel Bates from comment #3)
> Comment on attachment 413536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413536&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineGeometry.h:38
> > +    InlineLineGeometry(const InlineRect& lineLogicalRect, const InlineLayoutSize& lineBoxLogicalSize, InlineLayoutUnit aligmentBaseline, InlineLayoutUnit horizontalAlignmentOffset);
> 
> Ok as-is. Consider removing names for first 2 params now that they have
> different types.
I'd rather keep them as one is about the line while the other is about the line box geometry.