Bug 218633

Summary: [macOS] Remove mdnsresponder access from WebKit processes
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Brent Fulgham 2020-11-05 13:22:40 PST 
Now that all network loading (including media) happens in the Network process, we can remove an old permission to open outbound connections to mdnsresponder.
Comment 1 Brent Fulgham 2020-11-05 13:23:40 PST 
Note: This is also not needed in the GPU Process.
Comment 2 Brent Fulgham 2020-11-05 13:25:45 PST 
Created attachment 413348 [details]
Patch
Comment 3 Brent Fulgham 2020-11-05 13:26:26 PST 
<rdar://problem/69133548>
Comment 4 Per Arne Vollan 2020-11-05 13:35:49 PST 
Comment on attachment 413348 [details]
Patch

Great! R=me.
Comment 5 Alexey Proskuryakov 2020-11-05 15:50:51 PST 
Comment on attachment 413348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413348&action=review

> Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:-388
> -       (literal "/private/var/run/mDNSResponder")

Is this OK to do even though <rdar://problem/38240572> is NOT fixed? Looking as what it says, I suspect that mDNSResponder is still needed.
Comment 6 Brent Fulgham 2020-11-05 16:26:34 PST 
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 413348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413348&action=review
> 
> > Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:-388
> > -       (literal "/private/var/run/mDNSResponder")
> 
> Is this OK to do even though <rdar://problem/38240572> is NOT fixed? Looking
> as what it says, I suspect that mDNSResponder is still needed.

Yes. Although that particular CoreMedia bug is not fixed, we have moved all network loads out of the media process into WebKit. I found that trace (and filed the radar), and was not able to produce the same issue under modern WebKit.
Comment 7 EWS 2020-11-05 16:32:07 PST 
Committed r269491: <https://trac.webkit.org/changeset/269491>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413348 [details].
Comment 8 Brent Fulgham 2020-11-05 18:24:35 PST 
Reopening to attach new patch.
Comment 9 Brent Fulgham 2020-11-05 18:24:36 PST 
Created attachment 413382 [details]
Patch for landing
Comment 10 EWS 2020-11-05 19:07:33 PST 
Committed r269501: <https://trac.webkit.org/changeset/269501>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413382 [details].