Bug 218633

Summary: [macOS] Remove mdnsresponder access from WebKit processes
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2020-11-05 13:22:40 PST
Now that all network loading (including media) happens in the Network process, we can remove an old permission to open outbound connections to mdnsresponder.
Attachments
Patch (3.70 KB, patch)
2020-11-05 13:25 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.60 KB, patch)
2020-11-05 18:24 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-11-05 13:23:40 PST
Note: This is also not needed in the GPU Process.
Brent Fulgham
Comment 2 2020-11-05 13:25:45 PST
Created attachment 413348 [details] Patch
Brent Fulgham
Comment 3 2020-11-05 13:26:26 PST
<rdar://problem/69133548>
Per Arne Vollan
Comment 4 2020-11-05 13:35:49 PST
Comment on attachment 413348 [details] Patch Great! R=me.
Alexey Proskuryakov
Comment 5 2020-11-05 15:50:51 PST
Comment on attachment 413348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413348&action=review > Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:-388 > - (literal "/private/var/run/mDNSResponder") Is this OK to do even though <rdar://problem/38240572> is NOT fixed? Looking as what it says, I suspect that mDNSResponder is still needed.
Brent Fulgham
Comment 6 2020-11-05 16:26:34 PST
(In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 413348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413348&action=review > > > Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:-388 > > - (literal "/private/var/run/mDNSResponder") > > Is this OK to do even though <rdar://problem/38240572> is NOT fixed? Looking > as what it says, I suspect that mDNSResponder is still needed. Yes. Although that particular CoreMedia bug is not fixed, we have moved all network loads out of the media process into WebKit. I found that trace (and filed the radar), and was not able to produce the same issue under modern WebKit.
EWS
Comment 7 2020-11-05 16:32:07 PST
Committed r269491: <https://trac.webkit.org/changeset/269491> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413348 [details].
Brent Fulgham
Comment 8 2020-11-05 18:24:35 PST
Reopening to attach new patch.
Brent Fulgham
Comment 9 2020-11-05 18:24:36 PST
Created attachment 413382 [details] Patch for landing
EWS
Comment 10 2020-11-05 19:07:33 PST
Committed r269501: <https://trac.webkit.org/changeset/269501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413382 [details].
Note You need to log in before you can comment on or make changes to this bug.