Bug 218568

Summary: Add some missing header includes in media sources
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218426    
Attachments:
Description Flags
Patch eric.carlson: review+, wenson_hsieh: commit-queue+

Wenson Hsieh
Reported 2020-11-04 08:07:23 PST
I'm hitting some build errors when adding unified sources to the WebKit project; we need some minor adjustments to these files: - Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.h - Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp - Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.h
Attachments
Patch (3.26 KB, patch)
2020-11-04 08:10 PST, Wenson Hsieh 		eric.carlson: review+
wenson_hsieh: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-11-04 08:10:51 PST
Created attachment 413166 [details] Patch
Wenson Hsieh
Comment 2 2020-11-04 08:24:38 PST
Comment on attachment 413166 [details] Patch Thanks for the review!
Wenson Hsieh
Comment 3 2020-11-04 13:08:29 PST
Committed r269379: <https://trac.webkit.org/changeset/269379>
Note You need to log in before you can comment on or make changes to this bug.