| Summary: | [GPU Process] Move the internal GPU rendering flags from WebPage to WebProcess | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||
| Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sam, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=218600 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Said Abou-Hallawa
2020-11-03 18:29:45 PST
Created attachment 413133 [details]
Patch
Comment on attachment 413133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413133&action=review > Source/WebKit/ChangeLog:8 > + -- Setting UseGPUProcessForMedia is already in WebProcess. This is wrong, not something to be emulated > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:-697 > - webcoreBinding: none This is a layering violation. > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3266 > +- (BOOL)useGPUProcessForCanvasRenderingEnabled Clearly not. Created attachment 413141 [details]
Patch
Comment on attachment 413133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413133&action=review >> Source/WebKit/ChangeLog:8 >> + -- Setting UseGPUProcessForMedia is already in WebProcess. > > This is wrong, not something to be emulated I tried to fix it but RemoteMediaPlayerManager::updatePreferences() uses settings.useGPUProcessForMediaEnabled(). So I kept it as is. >> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:-697 >> - webcoreBinding: none > > This is a layering violation. Change was reverted back. >> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3266 >> +- (BOOL)useGPUProcessForCanvasRenderingEnabled > > Clearly not. Deleted. So should we fix the media flag? (In reply to Simon Fraser (smfr) from comment #5) > So should we fix the media flag? I'll try to fix it. Created attachment 413178 [details]
Patch
I wonder if we need to fail harder if something tries to make two WebPages with different GPUP settings coexist in the same WebProcess? Comment on attachment 413178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413178&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:719 > + webcoreBinding: none Nice! If this is no longer per-page, WebPreferences is not the right API to use to surface this, as that is a per-page concept. (In reply to Sam Weinig from comment #10) > If this is no longer per-page, WebPreferences is not the right API to use to > surface this, as that is a per-page concept. I filed bug 218600 to track this issue. Committed r269416: <https://trac.webkit.org/changeset/269416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413178 [details]. |