Bug 21846

Summary: Several DOM classes are missing specific constructors
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20430, 21842    
Attachments:
Description Flags
Add missing constructors and new test sam: review+

Eric Seidel (no email)
Reported 2008-10-23 17:58:00 PDT
Several DOM classes are missing specific constructors (instead they're inheriting generic object constructors from up their prototype chain. Patch coming up.
Attachments
Add missing constructors and new test (71.17 KB, patch)
2008-10-23 17:59 PDT, Eric Seidel (no email) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2008-10-23 17:59:05 PDT
Created attachment 24628 [details] Add missing constructors and new test LayoutTests/ChangeLog | 16 + .../fast/dom/Window/window-properties-expected.txt | 11 +- LayoutTests/fast/dom/wrapper-classes-expected.txt | 293 ++++++++++++- LayoutTests/fast/js/global-constructors.html | 13 + .../fast/js/resources/global-constructors.js | 25 + .../mac/fast/dom/wrapper-classes-expected.txt | 461 -------------------- WebCore/ChangeLog | 15 + WebCore/css/CSSStyleSheet.idl | 1 + WebCore/css/RGBColor.idl | 1 + WebCore/dom/NodeIterator.idl | 5 +- WebCore/dom/TreeWalker.idl | 5 +- WebCore/xml/XPathExpression.idl | 5 +- 12 files changed, 380 insertions(+), 471 deletions(-)
Eric Seidel (no email)
Comment 2 2008-10-23 18:00:31 PDT
Sadly the results file was in the wrong location, which makes this diff uglier. :(
Sam Weinig
Comment 3 2008-10-23 20:49:21 PDT
I don't think the JS binding for RGBColor is generated from RGBColor.idl, so I am not sure adding the attribute is doing anything.
Eric Seidel (no email)
Comment 4 2008-10-24 17:13:05 PDT
http://trac.webkit.org/changeset/37875
Note You need to log in before you can comment on or make changes to this bug.