Bug 218454

Summary: Add back swap() free function for RefPtr
Product: WebKit Reporter: Saam Barati <saam>
Component: Web Template FrameworkAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test EWS
none
patch none

Saam Barati
Reported 2020-11-02 12:52:25 PST
See: https://bugs.webkit.org/show_bug.cgi?id=199866#c40 and Darin's response
Attachments
test EWS (575 bytes, patch)
2020-11-02 14:50 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (1.39 KB, patch)
2020-11-05 11:32 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-11-02 12:53:40 PST
Darin's possible solution here seems like a good starting point: https://bugs.webkit.org/show_bug.cgi?id=199866#c42 Maybe we can also allow this for all PtrTraits, instead of opting some of them out
Saam Barati
Comment 2 2020-11-02 14:50:32 PST
Created attachment 412974 [details] test EWS Let's see what EWS thinks
Saam Barati
Comment 3 2020-11-05 11:32:43 PST
Created attachment 413334 [details] patch
EWS
Comment 4 2020-11-05 15:03:21 PST
Committed r269479: <https://trac.webkit.org/changeset/269479> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413334 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-05 15:04:19 PST
<rdar://problem/71096319>
Note You need to log in before you can comment on or make changes to this bug.