Bug 218454

Summary:

Add back swap() free function for RefPtr

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

Web Template Framework

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
test EWS	none
patch	none

Description Saam Barati 2020-11-02 12:52:25 PST

See: https://bugs.webkit.org/show_bug.cgi?id=199866#c40 and Darin's response

Comment 1 Saam Barati 2020-11-02 12:53:40 PST

Darin's possible solution here seems like a good starting point:
https://bugs.webkit.org/show_bug.cgi?id=199866#c42

Maybe we can also allow this for all PtrTraits, instead  of opting  some of them out

Comment 2 Saam Barati 2020-11-02 14:50:32 PST

Created attachment 412974 [details]
test EWS

Let's see what EWS thinks

Comment 3 Saam Barati 2020-11-05 11:32:43 PST

Created attachment 413334 [details]
patch

Comment 4 EWS 2020-11-05 15:03:21 PST

Committed r269479: <https://trac.webkit.org/changeset/269479>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413334 [details].

Comment 5 Radar WebKit Bug Importer 2020-11-05 15:04:19 PST

<rdar://problem/71096319>