Bug 218384

Summary:

Remove -webkit-aspect-ratio support

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

CSS

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=128629

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none

Rob Buis

Reported 2020-10-30 08:41:03 PDT

Remove -webkit-aspect-ratio support since it is superseded by aspect-ratio (https://www.w3.org/TR/css-sizing-4/).

Attachments
Patch (43.41 KB, patch) 2020-10-30 08:43 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (123.58 KB, patch) 2020-10-30 12:04 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (17.66 KB, patch) 2020-10-31 02:59 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (21.81 KB, patch) 2020-10-31 10:43 PDT, Rob Buis	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (25.51 KB, patch) 2020-10-31 12:04 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (26.30 KB, patch) 2020-11-02 01:54 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (50.01 KB, patch) 2020-11-14 01:38 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (130.75 KB, patch) 2020-11-14 02:36 PST, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2020-10-30 08:43:27 PDT

Created attachment 412747 [details] Patch

Rob Buis

Comment 2 2020-10-30 12:04:41 PDT

Created attachment 412784 [details] Patch

Simon Fraser (smfr)

Comment 3 2020-10-30 13:05:01 PDT

Comment on attachment 412784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412784&action=review > Source/WebCore/rendering/RenderReplaced.cpp:-121 > - float aspectRatio = m_intrinsicSize.aspectRatio(); > - LayoutSize frameSize = size(); > - float frameAspectRatio = frameSize.aspectRatio(); > - if (frameAspectRatio < aspectRatio) > - setHeight(computeReplacedLogicalHeightRespectingMinMaxHeight(frameSize.height() * frameAspectRatio / aspectRatio)); > - else if (frameAspectRatio > aspectRatio) > - setWidth(computeReplacedLogicalWidthRespectingMinMaxWidth(frameSize.width() * aspectRatio / frameAspectRatio, ComputePreferred)); > - } This was added in https://trac.webkit.org/changeset/164265/webkit so removing it is a behavior change, and we suspect that this might be used by (i)Books. I think we'll have to hold off on this change until we can determine that.

Rob Buis

Comment 4 2020-10-30 13:17:01 PDT

(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 412784 [details] > Patch > > This was added in https://trac.webkit.org/changeset/164265/webkit so > removing it is a behavior change, and we suspect that this might be used by > (i)Books. I think we'll have to hold off on this change until we can > determine that. Thanks for the heads up! Would it make sense to restrict -webkit-aspect-ratio support to only parse from-intrinsic/from-dimensions and remove auto/specified as a first step?

Simon Fraser (smfr)

Comment 5 2020-10-30 13:29:34 PDT

Yes I think that would be OK.

Rob Buis

Comment 6 2020-10-31 02:59:28 PDT

Created attachment 412837 [details] Patch

Rob Buis

Comment 7 2020-10-31 10:43:11 PDT

Created attachment 412847 [details] Patch

Rob Buis

Comment 8 2020-10-31 12:04:17 PDT

Created attachment 412850 [details] Patch