Bug 218347

Summary: JavaScriptCore should support multiple build variants
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, krollin, mark.lam, msaboff, ryuan.choi, sbarati, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
ews-feeder: commit-queue-
Patch v2 none

Description David Kilzer (:ddkilzer) 2020-10-29 11:30:10 PDT
JavaScriptCore should support multiple build variants.

This is something that typically only happens in Production configuration builds.  For engineering builds, BUILD_VARIANTS=normal.

<rdar://problem/70786057>
Comment 1 David Kilzer (:ddkilzer) 2020-10-29 11:37:15 PDT
Created attachment 412668 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-10-29 11:45:42 PDT
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 412668 [details]
> Patch v1

This script is used cross-platform, so we need a fallback when the "${BUILD_VARIANTS}" value is not passed on the command-line, or just pass "normal" for other ports.
Comment 3 David Kilzer (:ddkilzer) 2020-10-29 12:22:56 PDT
Created attachment 412671 [details]
Patch v2
Comment 4 Keith Miller 2020-10-29 12:29:18 PDT
Comment on attachment 412671 [details]
Patch v2

r=me seems reasonable
Comment 5 David Kilzer (:ddkilzer) 2020-10-29 14:26:02 PDT
Comment on attachment 412671 [details]
Patch v2

Marking cq+ since this patch can't have an effect on building DumpRenderTree for Windows.
Comment 6 EWS 2020-10-29 14:38:34 PDT
Committed r269171: <https://trac.webkit.org/changeset/269171>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412671 [details].