Bug 21832

Summary: Fix scripts using 'new File::Temp' for Perl 5.10
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: https://lists.webkit.org/pipermail/webkit-dev/2008-October/005489.html
Attachments:
Description Flags
Patch v1 sam: review+

David Kilzer (:ddkilzer)
Reported 2008-10-23 11:28:19 PDT
In Perl 5.10, the File::Temp module changed from this method of creating a new object: $fh = new File::Temp($template); To this method: $fh = File::Temp->new(TEMPLATE => $template); The apparent solution to this is to use File::Temp->tempfile() instead per: http://marc.info/?l=git&m=122089280626625&w=2
Attachments
Patch v1 (4.69 KB, patch)
2008-10-23 13:56 PDT, David Kilzer (:ddkilzer) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2008-10-23 12:22:59 PDT
These scripts are affected: JavaScriptCore/pcre/dftables WebKitTools/Scripts/bisect-builds WebKitTools/Scripts/sort-Xcode-project-file
David Kilzer (:ddkilzer)
Comment 2 2008-10-23 13:56:21 PDT
Created attachment 24615 [details] Patch v1 Note that using File::Temp->tempfile() instead of importing tempfile() first causes the template to be ignored, so I imported tempfile() and used it directly.
Sam Weinig
Comment 3 2008-10-23 16:14:40 PDT
Comment on attachment 24615 [details] Patch v1 Very nice.
David Kilzer (:ddkilzer)
Comment 4 2008-10-23 17:02:25 PDT
Committed r37832 http://trac.webkit.org/changeset/37832
Note You need to log in before you can comment on or make changes to this bug.