Bug 218306

Summary: Make run-webkit-test support filter attached devices by udid
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: New BugsAssignee: Zhifei Fang <zhifei_fang>
Status: NEW ---    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch zhifei_fang: review?

Description Zhifei Fang 2020-10-28 13:42:37 PDT
Make run-webkit-test support filter attached devices by udid
Comment 1 Zhifei Fang 2020-10-28 13:46:39 PDT
Created attachment 412570 [details]
Comment 2 Zhifei Fang 2020-10-28 13:48:16 PDT
Comment 3 Zhifei Fang 2020-10-28 13:56:14 PDT
This is also need an internal part
Comment 4 Aakash Jain 2020-10-28 15:50:09 PDT
Please check if it breaks layout tests on ios: https://ews-build.webkit.org/#/builders/51/builds/672

File "Tools/Scripts/webkitpy/port/device_port.py", line 47, in __init__
    self.udids = options.udid.split(',') if options and options.udid else None
AttributeError: Values instance has no attribute 'udid'
Comment 5 Radar WebKit Bug Importer 2020-11-04 12:43:17 PST
Comment 6 Zhifei Fang 2020-11-05 13:35:26 PST
Created attachment 413350 [details]
Comment 7 Zhifei Fang 2020-11-05 14:24:46 PST
Created attachment 413352 [details]
Comment 8 Jonathan Bedard 2020-11-05 16:30:54 PST
Comment on attachment 413352 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=413352&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:162
> +    def available_devices(host=None, udids=None):

Wanted to check before this landed, and it turns out that simulated devices do indeed have udidis, if we're passing this in, seems that we should use it.