Bug 218306

Summary: Make run-webkit-test support filter attached devices by udid
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: New BugsAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch zhifei_fang: review?

Zhifei Fang
Reported 2020-10-28 13:42:37 PDT
Make run-webkit-test support filter attached devices by udid
Attachments
Patch (3.72 KB, patch)
2020-10-28 13:46 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (4.40 KB, patch)
2020-11-05 13:35 PST, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (4.43 KB, patch)
2020-11-05 14:24 PST, Zhifei Fang 		zhifei_fang: review?
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2020-10-28 13:46:39 PDT
Created attachment 412570 [details] Patch
Zhifei Fang
Comment 2 2020-10-28 13:48:16 PDT
<rdar://34412623>
Zhifei Fang
Comment 3 2020-10-28 13:56:14 PDT
This is also need an internal part
Aakash Jain
Comment 4 2020-10-28 15:50:09 PDT
Please check if it breaks layout tests on ios: https://ews-build.webkit.org/#/builders/51/builds/672 File "Tools/Scripts/webkitpy/port/device_port.py", line 47, in __init__ self.udids = options.udid.split(',') if options and options.udid else None AttributeError: Values instance has no attribute 'udid'
Radar WebKit Bug Importer
Comment 5 2020-11-04 12:43:17 PST
<rdar://problem/71047801>
Zhifei Fang
Comment 6 2020-11-05 13:35:26 PST
Created attachment 413350 [details] Patch
Zhifei Fang
Comment 7 2020-11-05 14:24:46 PST
Created attachment 413352 [details] Patch
Jonathan Bedard
Comment 8 2020-11-05 16:30:54 PST
Comment on attachment 413352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413352&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:162 > + def available_devices(host=None, udids=None): Wanted to check before this landed, and it turns out that simulated devices do indeed have udidis, if we're passing this in, seems that we should use it.
Sam Sneddon [:gsnedders]
Comment 9 2025-01-16 13:43:04 PST
*** This bug has been marked as a duplicate of bug 282198 ***
Note You need to log in before you can comment on or make changes to this bug.