Summary: | Make run-webkit-test support filter attached devices by udid | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zhifei Fang <zhifei_fang> | ||||||||
Component: | New Bugs | Assignee: | Zhifei Fang <zhifei_fang> | ||||||||
Status: | NEW --- | ||||||||||
Severity: | Normal | CC: | aakash_jain, ews-watchlist, glenn, jbedard, webkit-bug-importer, zhifei_fang | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Zhifei Fang
2020-10-28 13:42:37 PDT
Created attachment 412570 [details]
Patch
This is also need an internal part Please check if it breaks layout tests on ios: https://ews-build.webkit.org/#/builders/51/builds/672 File "Tools/Scripts/webkitpy/port/device_port.py", line 47, in __init__ self.udids = options.udid.split(',') if options and options.udid else None AttributeError: Values instance has no attribute 'udid' Created attachment 413350 [details]
Patch
Created attachment 413352 [details]
Patch
Comment on attachment 413352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413352&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:162 > + def available_devices(host=None, udids=None): Wanted to check before this landed, and it turns out that simulated devices do indeed have udidis, if we're passing this in, seems that we should use it. |