Bug 218293

Summary:

AX: Incorrect list of voices being displayed on iOS

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, pvollan, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	ews-feeder: commit-queue-
patch	ews-feeder: commit-queue-
patch	ews-feeder: commit-queue-
patch	none
patch	none
patch	none
patch	none
patch	pvollan: review+
patch	none

chris fleizach

Reported 2020-10-28 10:45:06 PDT

For WebSpeech, we want WebKit to only show built-in system voices. <rdar://problem/70741038>

Attachments
patch (8.54 KB, patch) 2020-10-28 10:47 PDT, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (8.57 KB, patch) 2020-10-28 11:06 PDT, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (8.60 KB, patch) 2020-10-28 11:51 PDT, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (9.21 KB, patch) 2020-10-28 13:09 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (9.17 KB, patch) 2020-10-28 13:27 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (9.19 KB, patch) 2020-10-28 17:22 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (8.42 KB, patch) 2020-10-29 10:17 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (9.72 KB, patch) 2020-10-29 14:26 PDT, chris fleizach	pvollan: review+	Details Formatted Diff Diff
patch (9.68 KB, patch) 2020-10-30 11:25 PDT, chris fleizach	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2020-10-28 10:47:24 PDT

Created attachment 412545 [details] patch

chris fleizach

Comment 2 2020-10-28 11:06:17 PDT

Created attachment 412547 [details] patch

chris fleizach

Comment 3 2020-10-28 11:51:55 PDT

Created attachment 412557 [details] patch

chris fleizach

Comment 4 2020-10-28 13:09:30 PDT

Created attachment 412565 [details] patch

chris fleizach

Comment 5 2020-10-28 13:27:10 PDT

Created attachment 412568 [details] patch

chris fleizach

Comment 6 2020-10-28 17:22:22 PDT

Created attachment 412592 [details] patch

chris fleizach

Comment 7 2020-10-29 10:17:04 PDT

Created attachment 412664 [details] patch

chris fleizach

Comment 8 2020-10-29 14:26:22 PDT

Created attachment 412687 [details] patch

Per Arne Vollan

Comment 9 2020-10-30 11:22:28 PDT

Comment on attachment 412687 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=412687&action=review R=me. > Source/WebCore/PAL/pal/spi/cocoa/AXSpeechManagerSPI.h:38 > +WTF_EXTERN_C_BEGIN I don't think this is needed when you're declaring an interface.

chris fleizach

Comment 10 2020-10-30 11:25:43 PDT

Created attachment 412779 [details] patch addressed review comments

EWS

Comment 11 2020-10-30 15:59:15 PDT

Committed r269208: <https://trac.webkit.org/changeset/269208> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412779 [details].

Note You need to log in before you can comment on or make changes to this bug.