Bug 21827 – Memory leak in webkit_web_view_load_string

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Michael Tross]

The Gtk method webkit_web_view_load_string() takes a string as gchar* argument to set the page content. This string is passed down to a SharedBuffer, but duplicated before with strdup(), this memory is lost (verified with valgrind).

void webkit_web_view_load_string(WebKitWebView* webView, const gchar* content, const gchar* contentMimeType, const gchar* contentEncoding, const 
{
    ....

    RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(strdup(content), strlen(content));
    SubstituteData substituteData(sharedBuffer.release(), contentMimeType ? String(contentMimeType) : "text/html", contentEncoding ? String(conte

    ....
}

[Michael Tross]

Created attachment 24595 [details]
Patch to fix memory leak in webkit_web_view_load_string()

[Mark Rowe (bdash)]

This looks fine, but the patch needs a ChangeLog entry.  Can you please add one, and upload the new patch?  Be sure to set the "review" flag on the attachment to "?" when you upload the patch to indicate that you'd like it reviewed!

[Michael Tross]

Created attachment 24638 [details]
Patch to fix memory leak in webkit_web_view_load_string()

added ChangeLog entry and requested review

[Alp Toker]

Comment on attachment 24638 [details]
Patch to fix memory leak in webkit_web_view_load_string()

r=me

[Jan Alonzo]

Landed in r37903. Cheers.