Summary: | Add accessor for SecurityOrigin::m_domainWasSetInDOM | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Adam Barth
2008-10-23 01:53:11 PDT
Created attachment 24594 [details]
le patch
Comment on attachment 24594 [details]
le patch
+ * Copyright (C) 2007-2008 Apple Inc. All rights reserved.
We like to use comma delineated years.
void setDomainFromDOM(const String& newDomain);
+ bool domainWasSetInDOM() const { return m_domainWasSetInDOM; }
These should be paragraphed together.
I am a little unclear about why this is necessary, the SecurityOrigin it self should be sufficient for a fast compare. Perhaps we can remove this later.
Fixed in http://trac.webkit.org/changeset/37814 > I am a little unclear about why this is necessary, the SecurityOrigin it self > should be sufficient for a fast compare. Perhaps we can remove this later. Yeah, maybe there is a better long term solution here. I think the fast path for comparing SecurityOrigins in V8 gets inlined into the JITed code and they want to avoid the function call overhead. (I might be wrong about this, V8 is pretty mysterious to me.) It's similar to how JavaScriptCore doesn't bother calling SecurityOrigin::canAccess if a frame is accessing itself (the most common case) but taken to a little further extreme. |