Bug 21825

Summary: JSDOMBinding should not blindly cast the global object to JSDOMWindow
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore JavaScriptAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
proposed fix
mjs: review+
A better fix mjs: review+

Alexey Proskuryakov
Reported 2008-10-23 01:07:36 PDT
It might be a worker context, not a JSDOMWindow. Patch forthcoming.
Attachments
proposed fix (8.09 KB, patch)
2008-10-23 01:42 PDT, Alexey Proskuryakov 		mjs: review+
DetailsFormatted DiffDiff
A better fix (16.22 KB, patch)
2008-10-23 02:41 PDT, Alexey Proskuryakov 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-10-23 01:42:09 PDT
Created attachment 24592 [details] proposed fix
Maciej Stachowiak
Comment 2 2008-10-23 01:44:48 PDT
Comment on attachment 24592 [details] proposed fix r=me
Alexey Proskuryakov
Comment 3 2008-10-23 02:41:55 PDT
Created attachment 24593 [details] A better fix As proposed by Maciej on IRC, do not change JavaScriptCore, as the need is WebCore-specific.
Maciej Stachowiak
Comment 4 2008-10-23 02:43:16 PDT
Comment on attachment 24593 [details] A better fix r=me assuming it builds and passes tests
Alexey Proskuryakov
Comment 5 2008-10-23 03:16:29 PDT
Committed revision 37806.
Note You need to log in before you can comment on or make changes to this bug.