Bug 21825

Summary:

JSDOMBinding should not blindly cast the global object to JSDOMWindow

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore JavaScript

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
proposed fix	mjs: review+
A better fix	mjs: review+

Description Alexey Proskuryakov 2008-10-23 01:07:36 PDT

It might be a worker context, not a JSDOMWindow.

Patch forthcoming.

Comment 1 Alexey Proskuryakov 2008-10-23 01:42:09 PDT

Created attachment 24592 [details]
proposed fix

Comment 2 Maciej Stachowiak 2008-10-23 01:44:48 PDT

Comment on attachment 24592 [details]
proposed fix

r=me

Comment 3 Alexey Proskuryakov 2008-10-23 02:41:55 PDT

Created attachment 24593 [details]
A better fix

As proposed by Maciej on IRC, do not change JavaScriptCore, as the need is WebCore-specific.

Comment 4 Maciej Stachowiak 2008-10-23 02:43:16 PDT

Comment on attachment 24593 [details]
A better fix

r=me assuming it builds and passes tests

Comment 5 Alexey Proskuryakov 2008-10-23 03:16:29 PDT

Committed revision 37806.