Bug 21824

Summary: [GTK] FileSystem abstraction uses features from Glib 2.16
Product: WebKit Reporter: Kalle Vahlman <zuh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch to add wrapping for g_uri_unescape_string() alp: review+

Description Kalle Vahlman 2008-10-22 23:37:35 PDT
The FileSystem abstraction for GTK+ port uses g_uri_(un)escape_string() to escape file names on Linux, which are pretty new features introduced in Glib 2.16.

There's a wrapper and local copy of the implementation for g_uri_escape_string(), but not for g_uri_unescape_string() breaking the build for pre-2.16 Glib.
Comment 1 Kalle Vahlman 2008-10-22 23:41:45 PDT
Created attachment 24591 [details]
Patch to add wrapping for g_uri_unescape_string()

The patch follows the way the wrapping is done for g_uri_escape_string(), so it should be easy to review...
Comment 2 Alp Toker 2008-10-23 21:27:04 PDT
Comment on attachment 24591 [details]
Patch to add wrapping for g_uri_unescape_string()

r=me

Thanks for the fix. Will also add config.h to guriescape.c before landing.

Hopefully we'll end up using CString or something more appropriate for filenames some day!
Comment 3 Alp Toker 2008-10-23 21:33:22 PDT
Landed in r37838 with some tabs removed as required by the SVN commit hook.