Bug 218233

Summary: [LFC][Integration] Use iterator for next/previousLinePosition
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, mmaxfield, pdr, pnormand, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2020-10-27 07:41:19 PDT
In VisibleUnit.cpp
Attachments
patch (26.11 KB, patch)
2020-10-27 07:45 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-10-27 07:45:11 PDT
Created attachment 412420 [details] patch
zalan
Comment 2 2020-10-27 08:42:57 PDT
Comment on attachment 412420 [details] patch nice
EWS
Comment 3 2020-10-27 08:57:20 PDT
Committed r269041: <https://trac.webkit.org/changeset/269041> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412420 [details].
Radar WebKit Bug Importer
Comment 4 2020-10-27 08:58:19 PDT
<rdar://problem/70723663>
Philippe Normand
Comment 5 2020-10-27 10:14:44 PDT
This broke the Debian and Ubuntu LTS bots: https://build.webkit.org/builders/GTK-Linux-64-bit-Release-Debian-Stable-Build/builds/38868
Carlos Alberto Lopez Perez
Comment 6 2020-10-27 10:38:53 PDT
Seems is an issue with unified builds and includes. Those bots compile with different build options than the defaults so the include order on the unified builds is different. I have a fix for it, will land it
Carlos Alberto Lopez Perez
Comment 7 2020-10-27 10:43:41 PDT
Committed r269053: <https://trac.webkit.org/changeset/269053>
Note You need to log in before you can comment on or make changes to this bug.