Bug 218210

Summary: Improve exception messages when AudioContext.suspend() / resume() promises are rejected
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611, 217606    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-10-26 15:13:01 PDT
Improve exception messages when AudioContext.suspend() / resume() promises are rejected.
Attachments
Patch (5.44 KB, patch)
2020-10-26 15:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-26 15:14:59 PDT
Created attachment 412359 [details] Patch
Geoffrey Garen
Comment 2 2020-10-26 15:50:30 PDT
Comment on attachment 412359 [details] Patch r=me
Chris Dumez
Comment 3 2020-10-26 16:09:21 PDT
Comment on attachment 412359 [details] Patch Clearing flags on attachment: 412359 Committed r268999: <https://trac.webkit.org/changeset/268999>
Chris Dumez
Comment 4 2020-10-26 16:09:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-10-26 16:10:17 PDT
<rdar://problem/70699860>
Darin Adler
Comment 6 2020-10-26 17:38:37 PDT
Comment on attachment 412359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412359&action=review > LayoutTests/webaudio/construct-node-with-closed-context-expected.txt:45 > +PASS context.resume() rejected promise with InvalidStateError: Context is closed. > PASS context.close() rejected promise with InvalidStateError: The object is in an invalid state.. Why do some of our error messages end with periods, and others not?
Note You need to log in before you can comment on or make changes to this bug.