Bug 218200

Summary: [LFC][Integration] Use term "modern line layout" in RenderBlockFlow
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2020-10-26 12:24:02 PDT
modernize terminology
Attachments
patch (13.54 KB, patch)
2020-10-26 12:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-10-26 12:25:51 PDT
Created attachment 412344 [details] patch
Simon Fraser (smfr)
Comment 2 2020-10-26 13:02:21 PDT
This is the reverse of the direction we normally go. Don't use "new" or "modern": rename the old to legacy, and use no modifier for new code.
Antti Koivisto
Comment 3 2020-10-26 13:16:53 PDT
The plan is to use modern/legacy in the integration layer code. The actual new layout code doesn't use any qualifiers.
EWS
Comment 4 2020-10-26 13:23:53 PDT
Committed r268994: <https://trac.webkit.org/changeset/268994> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412344 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-26 13:24:16 PDT
<rdar://problem/70692601>
Note You need to log in before you can comment on or make changes to this bug.