Bug 218196 – Web Inspector: REGRESSION(r266695): Sources: override banner is squished for large images

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect <https://webkit.org>
2. create an override for `template.svg`

[Radar WebKit Bug Importer]

<rdar://problem/70736428>

[Patrick Angle]

Created attachment 413233 [details]
Patch

[Patrick Angle]

Created attachment 413235 [details]
Before Patch

[Patrick Angle]

Created attachment 413236 [details]
After Patch

[Devin Rousso]

Comment on attachment 413233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413233&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        This is resolved by making sure the minimum dimensions of the image containers are 0, so that the container can
> +        be `flex-shrink`ed.

That's ... odd.  The fact that we have to add `min-width`/`min-height` really feels like a bug :(

Could we use `flex-shrink`/`flex-grow` instead (maybe also on the banner node too)?

[Patrick Angle]

Comment on attachment 413233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413233&action=review

>> Source/WebInspectorUI/ChangeLog:11
>> +        be `flex-shrink`ed.
> 
> That's ... odd.  The fact that we have to add `min-width`/`min-height` really feels like a bug :(
> 
> Could we use `flex-shrink`/`flex-grow` instead (maybe also on the banner node too)?

I don't believe this is a bug; I just checked against FF and Chrome and observe the same behavior with a repro case, so really the previous behavior was a bug. Maybe I'm missing something, but no combination of flex-shrink and flex-grow is actually affecting the sizing in any meaningful way for me in any of the browsers.

[EWS]

Committed r269438: <https://trac.webkit.org/changeset/269438>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413233 [details].