Bug 218172 – [EME][GStreamer][Thunder] Make response parsing message more robust

• Component: New Bugs
• Status: RESOLVED FIXED

[Xabier Rodríguez Calvar]

[EME][GStreamer][Thunder] Make response parsing message more robust

[Xabier Rodríguez Calvar]

Created attachment 412301 [details]
Patch

[Xabier Rodríguez Calvar]

This patch will properly build when bug 218171 lands.

[Philippe Normand]

Comment on attachment 412301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412301&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:342
> +    explicit operator bool() const { return m_isValid; }
> +    bool operator!() const { return !m_isValid; }

What is the difference between this and hasType()? Can hasType() be removed then? I'm not sure casting an Optional<> to a bool works as expected anyway.

[Xabier Rodríguez Calvar]

(In reply to Philippe Normand from comment #3)
> Comment on attachment 412301 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412301&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:342
> > +    explicit operator bool() const { return m_isValid; }
> > +    bool operator!() const { return !m_isValid; }
> 
> What is the difference between this and hasType()? Can hasType() be removed
> then? I'm not sure casting an Optional<> to a bool works as expected anyway.

There is no difference. It is the same thing but it works similarly in Optional so I wanted to keep it parallel.

[Xabier Rodríguez Calvar]

Created attachment 412320 [details]
Patch

[EWS]

Committed r269030: <https://trac.webkit.org/changeset/269030>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412320 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70717329>