Bug 218164

Summary: [TextureMapper] min(genIType) isn't supported for GLSL ES < 3.0
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, don.olmstead, ews-watchlist, kondapallykalyan, luiz, magomez, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Description Fujii Hironori 2020-10-25 15:09:51 PDT 
[WinCairo] REGRESSION(r?): Nothing is drawn in AC mode

1. Start WinCairo MiniBrowser
2. Go to https://webkit.org/
3. Back blank page is shown

Workaround: Disable Accelerated Compositing

r268666: OK
r268956: Nothing shown
Comment 1 Fujii Hironori 2020-10-25 17:09:12 PDT 
this issue has started since r268923.
Comment 2 Fujii Hironori 2020-10-25 19:42:53 PDT 
I got the following shader error if debugging log is enabled.

$env:WebCoreLogging = "Compositing=debug"

> Fragment shader log: ERROR: 0:53: 'min' : no matching overloaded function found
> ERROR: 0:53: '=' : cannot convert from 'const mediump float' to 'mediump int'
Comment 3 Fujii Hironori 2020-10-25 19:55:44 PDT 
Created attachment 412286 [details]
WIP patch
Comment 4 Fujii Hironori 2020-10-25 21:05:02 PDT 
Created attachment 412288 [details]
Patch
Comment 5 Miguel Gomez 2020-10-26 01:13:12 PDT 
(In reply to Fujii Hironori from comment #4)
> Created attachment 412288 [details]
> Patch

Ooops, my bad!!

The patch looks good to me. Thanks Fujii!
Comment 6 Fujii Hironori 2020-10-26 12:57:51 PDT 
Comment on attachment 412288 [details]
Patch

Clearing flags on attachment: 412288

Committed r268992: <https://trac.webkit.org/changeset/268992>
Comment 7 Fujii Hironori 2020-10-26 12:57:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-10-26 12:58:17 PDT 
<rdar://problem/70691591>