Bug 218140

Summary: Web Inspector: URL breakpoints should also pause when HTML attributes that trigger loads are set
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] WIP
none
[Patch] WIP none

Devin Rousso
Reported 2020-10-23 15:28:31 PDT
Right now, URL breakpoints are limited to XHR and fetch. They should really include anything that can trigger network activity (but realistically we only care about situations where that trigger is some JavaScript code). ``` let image = new Image; image.src = "foo.png"; // should be able to pause here ```
Attachments
[Patch] WIP (15.19 KB, patch)
2020-10-23 22:26 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Patch] WIP (15.08 KB, patch)
2020-10-23 22:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-10-23 15:28:49 PDT
<rdar://problem/70636814>
Devin Rousso
Comment 2 2020-10-23 22:26:37 PDT
Created attachment 412231 [details] [Patch] WIP first attempt that uses the same instrumentation point as `Network` to pause whenever a request is sent
Devin Rousso
Comment 3 2020-10-23 22:33:11 PDT
Created attachment 412233 [details] [Patch] WIP rebase
EWS Watchlist
Comment 4 2020-10-23 22:34:58 PDT
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Blaze Burg
Comment 5 2020-10-26 16:54:46 PDT
Comment on attachment 412233 [details] [Patch] WIP LGTM so far, looks like the tests need some fixing.
Devin Rousso
Comment 6 2022-09-11 13:28:36 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4239
EWS
Comment 7 2022-09-14 12:47:28 PDT
Committed 254488@main (7ad0216f7c41): <https://commits.webkit.org/254488@main> Reviewed commits have been landed. Closing PR #4239 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.