Bug 218135 – Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Uncaught Exceptions:
-----------------------
 - TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth') (at ComputedStyleDetailsPanel.js:42:40)
    minimumWidth @ ComputedStyleDetailsPanel.js:42:40
    minimumWidth @ GeneralStyleDetailsSidebarPanel.js:48:68
    minimumWidth @ Sidebar.js:160:76
    minimumWidth @ SingleSidebar.js:57:33
    _updateMinimumWidthForMultipleSidebars @ MultiSidebar.js:189:55
    didRemoveSidebarPanel @ MultiSidebar.js:170:52
    removeSidebarPanel @ Sidebar.js:87:35
    showDetailsSidebarPanels @ ContentBrowserTabContentView.js:200:53
    _contentBrowserCurrentRepresentedObjectsDidChange @ ContentBrowserTabContentView.js:326:38
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    ? @ ContentBrowser.js:96:42
    _execute @ Debouncer.js:132:29
    force @ Debouncer.js:63:22
    _currentContentViewDidChange @ ContentBrowser.js:547:72
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    closeAllContentViews @ ContentViewContainer.js:303:38
    performSearch @ SearchSidebarPanel.js:129:70
    _searchFieldChanged @ SearchSidebarPanel.js:349:27
    _searchFieldChanged @ [native code]
-----------------------

Notes:
Inspected URL:        https://www.search-results.com/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko)

[Patrick Angle]

Repro steps:
0. Make sure the details sidebar is collapsed in the Search Tab and visible in the Elements Tab. Also ensure the Experimental `Show Independent Styles sidebar` option is enabled.
1. Open a new window to `webkit.org`.
2. Inspect the page and perform a global search (Shift+Command+F) for `webkit`.
3. Select one of the DOM node entries for an element (has a Purple square with the letter E for an icon).

This issue does not seem to happen when the experimental option is disabled, or if the sidebar was visible in the Search Tab before selecting the DOM node element entry.

[Patrick Angle]

Created attachment 412250 [details]
Patch

[Blaze Burg]

Comment on attachment 412250 [details]
Patch

r=me

[EWS]

Committed r268982: <https://trac.webkit.org/changeset/268982>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412250 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70684549>