Summary: | Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'value.truncate') | ||
---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> |
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | fbucchi, hi, inspector-bugzilla-changes, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
URL: | https://www.cbc.ca/account/profile | ||
Attachments: |
Description
Devin Rousso
2020-10-21 16:46:30 PDT
(In reply to Devin Rousso from comment #0) > not really sure what I was doing, but I was looking at cookies :| sorry i meant session storage 😅 Created attachment 412482 [details]
Fix Uncaught Exception: undefined is not an object (evaluating 'value.truncate')
Comment on attachment 412482 [details]
Fix Uncaught Exception: undefined is not an object (evaluating 'value.truncate')
r-, as this covers up the issue instead of solving it
I think the real problem is that `WI.DOMStorageObject.Event.ItemUpdated` dispatches with `{key, oldValue, newValue}` but `WI.DOMStorageContentView.prototype.itemUpdated` uses `value`.
Created attachment 412506 [details]
Fix Uncaught Exception: undefined is not an object (evaluating 'value.truncate')
Comment on attachment 412506 [details] Fix Uncaught Exception: undefined is not an object (evaluating 'value.truncate') View in context: https://bugs.webkit.org/attachment.cgi?id=412506&action=review > Source/WebInspectorUI/UserInterface/Models/DOMStorageObject.js:130 > - itemUpdated(key, oldValue, newValue) > + itemUpdated(key, value) This has to stay as it was before, as this is being called by `WI.DOMStorageObserver.prototype.domStorageItemUpdated` which comes from the protocol. Basically, I think all you need to do is change `{key, oldValue, newValue}` to `{key, value: newValue}`. Created attachment 412581 [details]
Fix Uncaught Exception: undefined is not an object (evaluating 'value.truncate')
Created attachment 412696 [details]
Patch
Comment on attachment 412696 [details]
Patch
r=me
Committed r269175: <https://trac.webkit.org/changeset/269175> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412696 [details]. |