Bug 218060

Summary: [LFC][IFC] Handle line box sizing quirks at the line box level
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

alan
Reported 2020-10-21 16:45:16 PDT
and not by stretching the inline level boxes
Attachments
Patch (14.21 KB, patch)
2020-10-21 17:29 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.65 KB, patch)
2020-10-21 19:01 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.50 KB, patch)
2020-10-22 06:17 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.53 KB, patch)
2020-10-22 06:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-10-21 17:29:44 PDT
Created attachment 412053 [details] Patch
alan
Comment 2 2020-10-21 19:01:18 PDT
*** Bug 217941 has been marked as a duplicate of this bug. ***
alan
Comment 3 2020-10-21 19:01:50 PDT
Created attachment 412058 [details] Patch
Antti Koivisto
Comment 4 2020-10-22 06:09:16 PDT
Comment on attachment 412058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412058&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:359 > + if (inlineLevelBox.isEmpty()) > + return false; > + return quirks.shouldInlineLevelBoxStretchLineBox(lineBox, inlineLevelBox); maybe the inlineLevelBox.isEmpty() test could go to the quirk too so the lambda would go away?
alan
Comment 5 2020-10-22 06:17:46 PDT
Created attachment 412088 [details] Patch
alan
Comment 6 2020-10-22 06:21:06 PDT
Created attachment 412090 [details] Patch
EWS
Comment 7 2020-10-22 07:44:03 PDT
Committed r268864: <https://trac.webkit.org/changeset/268864> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412090 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-22 07:45:31 PDT
<rdar://problem/70573591>
Note You need to log in before you can comment on or make changes to this bug.