Bug 218024

Summary: Simplify DumpRenderTree WebPreferences reset
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2020-10-21 08:11:29 PDT 
Simplify DumpRenderTree reset by using a new WebPreferences for each test
Comment 1 Sam Weinig 2020-10-21 08:12:02 PDT 
Created attachment 411985 [details]
Patch
Comment 2 Aakash Jain 2020-10-21 16:13:42 PDT 
Comment on attachment 411985 [details]
Patch

r- since it breaks wk1 tests. 30+ failures and 500k+ log lines in layout-tests (which is unusually high).
Comment 3 Sam Weinig 2020-10-21 17:30:35 PDT 
There is no need to r- patches that are not up for review.
Comment 4 Radar WebKit Bug Importer 2020-10-28 08:12:16 PDT 
<rdar://problem/70764568>
Comment 5 Sam Weinig 2020-11-01 16:45:42 PST Comment hidden (obsolete)
Comment 6 Sam Weinig 2021-02-23 12:52:31 PST Comment hidden (obsolete)
Comment 7 Sam Weinig 2021-03-06 09:41:55 PST 
Created attachment 422496 [details]
Patch
Comment 8 Simon Fraser (smfr) 2021-03-06 10:35:24 PST 
Comment on attachment 422496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422496&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:1631
> +    if (_private->updateBatchCount <= 0)

It's unsigned so it can never be < 0
Comment 9 EWS 2021-03-06 10:45:40 PST 
Committed r274040: <https://commits.webkit.org/r274040>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422496 [details].