Bug 218024

Summary: Simplify DumpRenderTree WebPreferences reset
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2020-10-21 08:11:29 PDT
Simplify DumpRenderTree reset by using a new WebPreferences for each test
Attachments
Patch (1.22 KB, patch)
2020-10-21 08:12 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (1.24 KB, patch)
2020-11-01 16:45 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (26.48 KB, patch)
2021-02-23 12:52 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (15.03 KB, patch)
2021-03-06 09:41 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-21 08:12:02 PDT
Created attachment 411985 [details] Patch
Aakash Jain
Comment 2 2020-10-21 16:13:42 PDT
Comment on attachment 411985 [details] Patch r- since it breaks wk1 tests. 30+ failures and 500k+ log lines in layout-tests (which is unusually high).
Sam Weinig
Comment 3 2020-10-21 17:30:35 PDT
There is no need to r- patches that are not up for review.
Radar WebKit Bug Importer
Comment 4 2020-10-28 08:12:16 PDT
<rdar://problem/70764568>
Sam Weinig
Comment 5 2020-11-01 16:45:42 PST Comment hidden (obsolete)
Sam Weinig
Comment 6 2021-02-23 12:52:31 PST Comment hidden (obsolete)
Sam Weinig
Comment 7 2021-03-06 09:41:55 PST
Created attachment 422496 [details] Patch
Simon Fraser (smfr)
Comment 8 2021-03-06 10:35:24 PST
Comment on attachment 422496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422496&action=review > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:1631 > + if (_private->updateBatchCount <= 0) It's unsigned so it can never be < 0
EWS
Comment 9 2021-03-06 10:45:40 PST
Committed r274040: <https://commits.webkit.org/r274040> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422496 [details].
Note You need to log in before you can comment on or make changes to this bug.