Bug 218021

Summary: [Flatpak SDK] Backport GStreamer device monitor patch
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217959    
Attachments:
Description Flags
Patch none

Comment 1 Philippe Normand 2020-10-21 07:22:42 PDT 
Created attachment 411982 [details]
Patch
Comment 2 Adrian Perez 2020-10-22 04:53:10 PDT 
Side comment: should we also add this patch to the JHBuild moduleset
in a follow-up patch?
Comment 3 Philippe Normand 2020-10-22 06:23:34 PDT 
(In reply to Adrian Perez from comment #2)
> Side comment: should we also add this patch to the JHBuild moduleset
> in a follow-up patch?

Feel free to do it, but it's not strictly needed, unless the LTS bots ever need to run webaudio layout tests.
Comment 4 EWS 2020-10-22 06:41:01 PDT 
Committed r268863: <https://trac.webkit.org/changeset/268863>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411982 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-22 06:41:23 PDT 
<rdar://problem/70572104>
Comment 6 Adrian Perez 2020-10-22 10:35:08 PDT 
(In reply to Philippe Normand from comment #3)
> (In reply to Adrian Perez from comment #2)
> > Side comment: should we also add this patch to the JHBuild moduleset
> > in a follow-up patch?
> 
> Feel free to do it, but it's not strictly needed, unless the LTS bots ever
> need to run webaudio layout tests.

I don't expect they will, and IIRC the LTS bots use system dependencies
anyway because their goal is to ensure that we don't break the build in
the oldest distributions we need to support — let's skip adding this patch
in the JHBuild moduleset, then :)