Bug 21802

Summary: Rename HAVE_ACCESSIBILITY to ENABLE_ACCESSIBILITY
Product: WebKit Reporter: Sam Weinig <sam>
Component: AccessibilityAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, alp, darin, ddkilzer, fujii.hironori, ross.kirsling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199625
Attachments:
Description Flags
Patch achristensen: review+

Sam Weinig
Reported 2008-10-22 10:16:01 PDT
While the current macros for platforms/features are not entirely clear or fleshed out, it doesn't really make sense for accessibility to be a HAVE.
Attachments
Patch (72.98 KB, patch)
2018-11-13 20:54 PST, Fujii Hironori 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2008-11-08 04:41:42 PST
See Bug 21443 Comment #2 and Bug 21443 Comment #3.
Fujii Hironori
Comment 2 2018-11-13 20:54:41 PST
Created attachment 354763 [details] Patch
Fujii Hironori
Comment 3 2018-11-13 20:57:22 PST
Here is the command I invoked. > sed -i -e 's/HAVE_ACCESSIBILITY/ENABLE_ACCESSIBILITY/' Source/WTF/wtf/Platform.h > git ls-files -z Source Tools | egrep -z '\.(h|c|cpp|m|mm)$' | xargs --null grep -lZ 'HAVE(ACCESSIBILITY)' | xargs --null sed -i -e 's/HAVE(ACCESSIBILITY)/ENABLE(ACCESSIBILITY)/' Then, I checked the remaining HAVE_ACCESSIBILITY and HAVE(ACCESSIBILITY). > git ls-files -z . | xargs --null grep 'HAVE.ACCESSIBILITY' I confirmed it shows only ChangeLogs and PerformanceTests.
Fujii Hironori
Comment 4 2018-11-14 16:53:57 PST
AppleWin EWS failed. > C:\cygwin\home\buildbot\WebKit\Source\WebCore\accessibility\win\AXObjectCacheWin.cpp(46): error C2084: function 'void WebCore::AXObjectCache::detachWrapper(WebCore::AccessibilityObject *,WebCore::AccessibilityDetachmentType)' already has a body
Fujii Hironori
Comment 5 2018-11-14 17:12:29 PST
Thank you for the review. But, I changed my mind. I think I should ask removing HAVE_ACCESSIBILITY in webkit-dev.
Ross Kirsling
Comment 6 2018-11-14 18:21:59 PST
(In reply to Fujii Hironori from comment #5) > Thank you for the review. > But, I changed my mind. I think I should ask removing HAVE_ACCESSIBILITY in > webkit-dev. I don't think you need to hesitate -- it seems to be an existing mistake that AXObjectCacheWin.cpp has no #if HAVE(ACCESSIBILITY) wrapper.
Fujii Hironori
Comment 7 2018-11-26 20:23:55 PST
We decided not to rename. WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.