Bug 218004 – [iOS] Prevent presentation of input peripherals when focusing form controls with a validation message

• Component: Forms
• Status: RESOLVED FIXED

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/70507678>

[Aditya Keerthi]

Created attachment 411939 [details]
Patch

[Wenson Hsieh]

Comment on attachment 411939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411939&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:537
> +    m_willShowValidationMessage = true;

Is it possible for this to be called twice in the same runloop? If so, we should consider making this a counter and incrementing/decrementing it instead (and then `HTMLFormControlElement::willShowValidationMessage` would return true if the count is nonzero).

[Aditya Keerthi]

Created attachment 412063 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 411939 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411939&action=review
> 
> > Source/WebCore/html/HTMLFormControlElement.cpp:537
> > +    m_willShowValidationMessage = true;
> 
> Is it possible for this to be called twice in the same runloop? If so, we
> should consider making this a counter and incrementing/decrementing it
> instead (and then `HTMLFormControlElement::willShowValidationMessage` would
> return true if the count is nonzero).

Discussed this offline. Since the flag only needs to be true around the call to focus(), I moved the reset outside of the asynchronous call to `updateVisibleValidationMessage`, and renamed the flag to m_isFocusingWithValidationMessage.

[EWS]

Committed r268866: <https://trac.webkit.org/changeset/268866>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412063 [details].

[Simon Fraser (smfr)]

*** Bug 220593 has been marked as a duplicate of this bug. ***