Bug 217926

Summary: Drop explicit calls to BaseAudioContext::refNode()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-10-19 15:49:09 PDT
Drop explicit calls to BaseAudioContext::refNode(). We now use the sourceNodeWillBeginPlayback() signal to ref the node.
Attachments
Patch (23.18 KB, patch)
2020-10-19 16:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-19 16:04:26 PDT
Created attachment 411808 [details] Patch
EWS
Comment 2 2020-10-20 08:02:23 PDT
Committed r268728: <https://trac.webkit.org/changeset/268728> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411808 [details].
Radar WebKit Bug Importer
Comment 3 2020-10-20 08:03:18 PDT
<rdar://problem/70485202>
Note You need to log in before you can comment on or make changes to this bug.