Bug 217834

Summary: [build.webkit.org] Use feature flag to support Buildbot 2 code
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2020-10-16 10:22:05 PDT
Use feature flag in build.webkit.org code to support both Buildbot 0.8 as well as Buildbot 2 code. Current code is for Buildbot 0.8. We are planning to update to latest Buildbot (https://bugs.webkit.org/show_bug.cgi?id=175056).
Attachments
Patch (4.91 KB, patch)
2020-10-16 10:25 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2020-10-16 13:28 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-16 10:25:08 PDT
Created attachment 411595 [details] Patch
Aakash Jain
Comment 2 2020-10-16 10:37:08 PDT
Tested on uat instance.
Aakash Jain
Comment 3 2020-10-16 13:28:00 PDT
Created attachment 411608 [details] Patch
Jonathan Bedard
Comment 4 2020-10-16 13:36:22 PDT
Comment on attachment 411608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411608&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:161 > + builder['category'] = category Weren't we setting the category before? This seems like a change in behavior for the current buildbot.
Aakash Jain
Comment 5 2020-10-16 13:43:45 PDT
Comment on attachment 411608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411608&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:161 >> + builder['category'] = category > > Weren't we setting the category before? This seems like a change in behavior for the current buildbot. We were setting builder['category'] before as well. Now we are setting the 'category' variable and later assigning it to builder['category'], but only for old-buildbot-version. There shouldn't be any change in behavior for current buildbot (0.8.6p1). For new Buildbot version we will be using tags (in subsequent patch). As per http://docs.buildbot.net/latest/relnotes/0.9.0.html#changes-and-removals "Builders now have “tags” instead of a category. Builders can have multiple tags, allowing more flexible builder displays."
EWS
Comment 6 2020-10-19 11:17:23 PDT
Committed r268674: <https://trac.webkit.org/changeset/268674> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411608 [details].
Radar WebKit Bug Importer
Comment 7 2020-10-19 11:18:26 PDT
<rdar://problem/70448398>
Aakash Jain
Comment 8 2020-10-20 08:43:36 PDT
(In reply to Aakash Jain from comment #5) > For new Buildbot version we will be using tags (in subsequent patch). Adding tags for new Buildbot version in https://bugs.webkit.org/show_bug.cgi?id=217958
Note You need to log in before you can comment on or make changes to this bug.