Bug 217818

Summary: sdpFmtLine should be missing from RTCRtpCodecCapability instead of being an empty string
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-10-16 05:43:43 PDT
sdpFmtLine should be missing from RTCRtpCodecCapability instead of being an empty string
Attachments
Patch (4.21 KB, patch)
2020-10-16 05:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-10-16 05:44:15 PDT
This makes https://webrtc.github.io/samples/src/content/peerconnection/change-codecs/ failing
youenn fablet
Comment 2 2020-10-16 05:45:49 PDT
Created attachment 411561 [details] Patch
EWS
Comment 3 2020-10-16 08:38:34 PDT
Committed r268592: <https://trac.webkit.org/changeset/268592> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411561 [details].
Radar WebKit Bug Importer
Comment 4 2020-10-16 08:39:19 PDT
<rdar://problem/70379088>
Darin Adler
Comment 5 2020-10-16 09:31:48 PDT
Comment on attachment 411561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411561&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:415 > + sdpFmtpLine = sdpFmtpLineBuilder.toString(); In future, for cases like this I think we might want to add a nullIfEmpty function that takes a String&& and returns a String. Seems a shame to add a local variable just for this transformation. Although that "llIf" sequence makes the function name ugly.
Note You need to log in before you can comment on or make changes to this bug.