Bug 217811

Summary: WebRTC VP9 Decoder should be able to use VTB
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-10-16 05:09:30 PDT
WebRTC VP9 Decoder should be able to use VTB
Attachments
Patch (45.27 KB, patch)
2020-10-16 05:15 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (45.40 KB, patch)
2020-10-16 05:19 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (45.41 KB, patch)
2020-10-16 05:48 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (42.99 KB, patch)
2020-10-16 06:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (59.77 KB, patch)
2020-10-19 02:35 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (59.48 KB, patch)
2020-10-19 02:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (60.81 KB, patch)
2020-10-19 06:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.92 KB, patch)
2020-10-21 08:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-10-16 05:15:15 PDT
Created attachment 411558 [details] Patch
youenn fablet
Comment 2 2020-10-16 05:19:40 PDT
Created attachment 411559 [details] Patch
youenn fablet
Comment 3 2020-10-16 05:48:56 PDT
Created attachment 411562 [details] Patch
youenn fablet
Comment 4 2020-10-16 06:00:32 PDT
Created attachment 411563 [details] Patch
youenn fablet
Comment 5 2020-10-19 02:35:13 PDT
Created attachment 411729 [details] Patch
youenn fablet
Comment 6 2020-10-19 02:38:12 PDT
Created attachment 411730 [details] Patch
youenn fablet
Comment 7 2020-10-19 06:06:01 PDT
Created attachment 411742 [details] Patch
Eric Carlson
Comment 8 2020-10-19 09:09:35 PDT
Comment on attachment 411742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411742&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:81 > + 64, //sizeof(WebKitVP9Decoder), Is this necessary? > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:65 > + return nullptr; Is it worth logging here? > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:70 > + return nullptr; Ditto
youenn fablet
Comment 9 2020-10-21 08:43:44 PDT
Created attachment 411989 [details] Patch for landing
EWS
Comment 10 2020-10-21 10:14:30 PDT
Committed r268805: <https://trac.webkit.org/changeset/268805> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411989 [details].
Radar WebKit Bug Importer
Comment 11 2020-10-21 10:15:25 PDT
<rdar://problem/70534222>
Note You need to log in before you can comment on or make changes to this bug.