Bug 217809

Summary:

[GPU Process] Exchange RemoteImageBuffer and RemoteImageBufferProxy

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Canvas

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, dino, eric.carlson, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, mkwst, philipj, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

217342

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Said Abou-Hallawa

Reported 2020-10-15 22:22:34 PDT

The ImageBuffer is a WebCore object. We inherit from it for different reasons and we allow different backends for all of the derived classes. For GPU rendering, we currently create an object of type RemoteImageBufferProxy in the GPU Process to own the backend. And to have access to this object, we create another object of type RemoteImageBuffer in the Web Process. The two classes, RemoteImageBufferProxy and RemoteImageBuffer, provide a seamlessly interface in WebCore. So the clients do not have to worry about when the rendering will take place to the backend in the GPU process. But the names of the GPU rendering classes have been confusing. RemoteImageBuffer should be the real object in the GPU Process because it owns the backend. And RemoteImageBufferProxy should be a proxy to this object in the Web Process. So we are going to exchange the following classes: RemoteImageBuffer <-> RemoteImageBufferProxy RemoteRenderingBackend <-> RemoteRenderingBackendProxy RemoteImageBufferMessageHandler <-> RemoteImageBufferMessageHandlerProxy

Attachments
Patch (145.15 KB, patch) 2020-10-15 22:28 PDT, Said Abou-Hallawa	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (79.73 KB, patch) 2020-10-16 00:28 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (146.65 KB, patch) 2020-10-16 00:54 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (80.29 KB, patch) 2020-10-16 01:12 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (146.65 KB, patch) 2020-10-16 12:45 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (145.61 KB, patch) 2020-10-16 14:00 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (145.61 KB, patch) 2020-10-16 14:25 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.