| Summary: | Cleanup duplicate per-platform baselines | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, ap, cfleizach, dbarton, dmazzoni, eric.carlson, ews-watchlist, fred.wang, glenn, graouts, jcraig, jdiggs, jer.noble, philipj, samuel_white, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=217788 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Sneddon [:gsnedders]
2020-10-15 16:51:23 PDT
Created attachment 411511 [details]
Patch
Comment on attachment 411511 [details]
Patch
rs=me, pending EWS.
Comment on attachment 411511 [details]
Patch
Gah, I didn't properly deal with the sequence of the fallbacks, so if mac-mojave-wk1 == generic and mac-wk1 != generic it incorrectly deletes the mac-mojave-wk1 file.
Created attachment 411515 [details]
Patch
Fixed up check-for-duplicated-platform-test-results to better match how we run things and used that script rather the one I hacked up from code I had for other things! Hopefully won't cause similar breakage again.
Committed r268589: <https://trac.webkit.org/changeset/268589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411515 [details]. |